Fix server shutdown for Python 3.10-3.12 #75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
asyncio.Queue.shutdown()withasyncio.Queue.put_nowait(None).YRoomandYRoomFileAPIreceives an item of valueNone, the background task watching that queue will shut down.Testing instructions
python=3.10andjupyterlab=4.4(our extension still requires JL >=4.4)jlpm dev:installFuture work