Route kernel messages about language_info, execution_state, and execution count into ydoc #90
Conversation
…tion count into ydoc
|
Addressed all comments in #81 |
|
I think we need to move the execution count out of the ydoc and into awareness. I'll do this in a separate PR. |
|
@Zsailer
duplicate-outputs.mov |
| # Specifically update the running cell's execution state if cell_id is provided | ||
| if cell_id: | ||
| notebook = await yroom.get_jupyter_ydoc() | ||
| _, target_cell = notebook.find_cell(cell_id) |
There was a problem hiding this comment.
@Zsailer
PR 80 also passed cells as a second argument here, is this missing? I can't locate the find_cell API in YNotebook or YBaseDoc to verify this.
https://github.com/jupyter-ai-contrib/jupyter-server-documents/pull/81/files#diff-7c1b5e5cd83f31f24af67c439d6a9422528ddb74a5b20598b25230a798d613d7R252-R253
There was a problem hiding this comment.
I moved this API to the ydocs.py module here. We don't need to pass the list of cells anymore, since that class already has the list as a property.
|
@3coins I think this is ready to go. I just rebuilt and tested and everything seems to be working well 🚀 |
2 participants
Supercedes #81