Skip to content

Commit b19d8f0

Browse files
committed
fix tests
1 parent df514e8 commit b19d8f0

File tree

1 file changed

+21
-10
lines changed

1 file changed

+21
-10
lines changed

tests/test_extension.py

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ async def test_start_extension_success(self):
7272
with patch("jupyter_server_mcp.extension.MCPServer") as mock_mcp_class:
7373
mock_server = Mock()
7474
mock_server.start_server = AsyncMock()
75-
mock_server._registered_tools = [] # Use list instead of Mock
75+
mock_server._registered_tools = {}
76+
mock_server._registered_prompts = {}
7677
mock_mcp_class.return_value = mock_server
7778

7879
await extension.start_extension()
@@ -163,7 +164,8 @@ async def test_full_lifecycle(self):
163164
with patch("jupyter_server_mcp.extension.MCPServer") as mock_mcp_class:
164165
mock_server = Mock()
165166
mock_server.start_server = AsyncMock()
166-
mock_server._registered_tools = [] # Use list instead of Mock
167+
mock_server._registered_tools = {}
168+
mock_server._registered_prompts = {}
167169
mock_mcp_class.return_value = mock_server
168170

169171
# Start extension
@@ -323,8 +325,8 @@ def test_register_configured_prompts_valid(self):
323325
extension = MCPExtensionApp()
324326
extension.mcp_server_instance = Mock()
325327
extension.mcp_prompts = [
326-
"package.prompts:code_review",
327-
"package.prompts:documentation",
328+
"os:getcwd",
329+
"json:dumps",
328330
]
329331

330332
# Capture log output
@@ -336,6 +338,12 @@ def test_register_configured_prompts_valid(self):
336338

337339
# Check log messages
338340
mock_logger.info.assert_any_call("Registering 2 prompts from configuration")
341+
mock_logger.info.assert_any_call(
342+
"✅ Registered prompt from configuration: os:getcwd"
343+
)
344+
mock_logger.info.assert_any_call(
345+
"✅ Registered prompt from configuration: json:dumps"
346+
)
339347

340348
def test_register_configured_prompts_with_errors(self):
341349
"""Test registering prompts when some fail to load."""
@@ -378,6 +386,7 @@ async def test_start_extension_with_tools(self):
378386
"getcwd": {},
379387
"sqrt": {},
380388
} # Mock registered tools
389+
mock_server._registered_prompts = {}
381390
mock_mcp_class.return_value = mock_server
382391

383392
await extension.start_extension()
@@ -401,6 +410,7 @@ async def test_start_extension_no_tools(self):
401410
mock_server = Mock()
402411
mock_server.start_server = AsyncMock()
403412
mock_server._registered_tools = {}
413+
mock_server._registered_prompts = {}
404414
mock_mcp_class.return_value = mock_server
405415

406416
await extension.start_extension()
@@ -495,6 +505,7 @@ async def test_start_extension_with_entrypoints_and_config(self):
495505
mock_server = Mock()
496506
mock_server.start_server = AsyncMock()
497507
mock_server._registered_tools = {"getcwd": {}, "dumps": {}}
508+
mock_server._registered_prompts = {}
498509
mock_mcp_class.return_value = mock_server
499510

500511
with patch.object(
@@ -593,17 +604,17 @@ async def test_start_extension_with_prompts_entrypoints_and_config(self):
593604
extension = MCPExtensionApp()
594605
extension.mcp_port = 3087
595606
extension.use_tool_discovery = True
596-
extension.mcp_prompts = ["package.prompts:config_prompt"]
607+
extension.mcp_prompts = ["json:dumps"]
597608

598-
discovered_prompts = ["package.prompts:discovered_prompt"]
609+
discovered_prompts = ["os:getcwd"]
599610

600611
with patch("jupyter_server_mcp.extension.MCPServer") as mock_mcp_class:
601612
mock_server = Mock()
602613
mock_server.start_server = AsyncMock()
603614
mock_server._registered_tools = {}
604615
mock_server._registered_prompts = {
605-
"discovered_prompt": {},
606-
"config_prompt": {},
616+
"getcwd": {},
617+
"dumps": {},
607618
}
608619
mock_mcp_class.return_value = mock_server
609620

@@ -626,13 +637,13 @@ async def test_start_extension_with_tools_and_prompts(self):
626637
extension = MCPExtensionApp()
627638
extension.mcp_port = 3088
628639
extension.mcp_tools = ["os:getcwd"]
629-
extension.mcp_prompts = ["package.prompts:review"]
640+
extension.mcp_prompts = ["json:dumps"]
630641

631642
with patch("jupyter_server_mcp.extension.MCPServer") as mock_mcp_class:
632643
mock_server = Mock()
633644
mock_server.start_server = AsyncMock()
634645
mock_server._registered_tools = {"getcwd": {}}
635-
mock_server._registered_prompts = {"review": {}}
646+
mock_server._registered_prompts = {"dumps": {}}
636647
mock_mcp_class.return_value = mock_server
637648

638649
with (

0 commit comments

Comments
 (0)