🤖 Update our TS config and bundler versions (#2499)

Co-authored-by: Rowan Cockett <[email protected]>

Author: agoose77

.changeset/chilly-mugs-look.md

@@ -0,0 +1,6 @@
+---
+'mystmd': minor
+'tsconfig': patch
+---
+
+Target Node18

packages/myst-to-docx/src/plugin.ts

@@ -11,6 +11,7 @@ export const plugin: Plugin<[Options], Root, VFile> = function (opts) {
     const state = new DocxSerializer(file, opts);
     state.renderChildren(node);
     const doc = createDocFromState(state);
+    // @ts-expect-error document is not defined in node
     if (typeof document === 'undefined') {
       file.result = Packer.toBuffer(doc);
     } else {

packages/myst-to-docx/src/utils.ts

@@ -86,8 +86,20 @@ export function getImageWidth(width?: number | string, maxWidth = MAX_DOCX_IMAGE
   return (lineWidth / 100) * maxWidth;
 }
 
-async function getImageDimensions(file: Blob | Buffer): Promise<{ width: number; height: number }> {
+/**
+ * Get the dimensions of an image using the browser's `Image` object.
+ * @param file - The image file.
+ * @returns The dimensions of the image.
+ * @note This is a browser only function, server side this function should return undefined
+ * and the `buffer-image-size` package should be used to get the dimensions.
+ */
+async function getImageDimensions(
+  file: Blob | Buffer,
+): Promise<{ width: number; height: number } | undefined> {
+  // @ts-expect-error Image is not defined
+  if (typeof Image === 'undefined') return undefined;
   return new Promise((resolve, reject) => {
+    // @ts-expect-error Image not defined
     const img = new Image();
     // the following handler will fire after a successful loading of the image
     img.onload = () => {
@@ -120,7 +132,10 @@ export async function fetchImagesAsBuffers(
       const response = await fetch(image.url);
       const blob = await response.blob();
       const buffer = await blob.arrayBuffer();
-      dimensions[image.url] = await getImageDimensions(blob);
+      const dims = await getImageDimensions(blob);
+      if (dims !== undefined) {
+        dimensions[image.url] = dims;
+      }
       buffers[image.url] = Buffer.from(buffer);
     }),
   );

packages/mystmd/package.json

@@ -37,7 +37,7 @@
     "lint:format": "npm run copy:version; prettier --check \"src/**/*.ts\"",
     "test": "npm run link; npm run copy:version; vitest run",
     "test:watch": "npm run link; npm run copy:version; vitest watch",
-    "build:cli": "esbuild src/index.ts --bundle --outfile=dist/myst.cjs --platform=node --external:fsevents --target=node14",
+    "build:cli": "esbuild src/index.ts --bundle --outfile=dist/myst.cjs --platform=node --external:fsevents --target=node18",
     "build": "npm-run-all -l clean copy:version -p build:cli"
   },
   "devDependencies": {

packages/tsconfig/base.json

@@ -5,20 +5,20 @@
     "composite": false,
     "declaration": true,
     "declarationMap": true,
-    "target": "ES2019",
+    "target": "es2022",
     "esModuleInterop": true,
     "forceConsistentCasingInFileNames": true,
     "inlineSources": false,
     "isolatedModules": true,
-    "module": "Node16",
-    "moduleResolution": "Node16",
+    "lib": ["es2022"],
+    "module": "node18",
+    "moduleResolution": "node16",
     "allowSyntheticDefaultImports": true,
     "noUnusedLocals": false,
     "noUnusedParameters": false,
     "preserveWatchOutput": true,
     "skipLibCheck": true,
     "strict": true,
-    "lib": ["es2021", "DOM"],
     "typeRoots": [
       "./types",
       "./node_modules/@types",