refactor: move user expression lowering into function

Author: agoose77

packages/myst-cli/src/process/notebook.ts

@@ -84,6 +84,21 @@ export async function processNotebook(
   return mdast;
 }
 
+/**
+ * Embed the Jupyter output data for a user expression into the AST
+ */
+function embedInlineExpressions(
+  userExpressions: IUserExpressionMetadata[] | undefined,
+  block: GenericNode,
+) {
+  const inlineNodes = selectAll('inlineExpression', block) as InlineExpression[];
+  inlineNodes.forEach((inlineExpression) => {
+    const data = findExpression(userExpressions, inlineExpression.value);
+    if (!data) return;
+    inlineExpression.result = data.result as unknown as Record<string, unknown>;
+  });
+}
+
 export async function processNotebookFull(
   session: ISession,
   file: string,
@@ -136,17 +151,7 @@ export async function processNotebookFull(
           return acc.concat(...cellMdast.children);
         }
         const block = blockParent(cell, cellMdast.children) as GenericNode;
-
-        // Embed expression results into expression
-        const userExpressions = block.data?.[metadataSection] as
-          | IUserExpressionMetadata[]
-          | undefined;
-        const inlineNodes = selectAll('inlineExpression', block) as InlineExpression[];
-        inlineNodes.forEach((inlineExpression) => {
-          const data = findExpression(userExpressions, inlineExpression.value);
-          if (!data) return;
-          inlineExpression.result = data.result as unknown as Record<string, unknown>;
-        });
+        embedInlineExpressions(block.data?.[metadataSection], block);
         return acc.concat(block);
       }
       if (cell.cell_type === CELL_TYPES.raw) {