Revert dialog acceptance, fix the menu item xpath

JupyterLab 3.4 has new "New Notebook" item which was wrongly
getting selected instead of the "Notebook" choice.

Author: krassowski

atest/Keywords.resource

@@ -281,20 +281,6 @@ Setup Notebook
     IF    ${isolated}    Try to Close All Tabs
     Open ${file} in ${MENU NOTEBOOK}
     Capture Page Screenshot    00-notebook-opened.png
-    # Kernel selection dialog may show up if the ipykernel version changed
-    # since the last time notebooks were updated; because we are testing
-    # with different ipykernel versions, this is inevitable. In such a case
-    # accept the suggested kernel choice
-    IF    ${wait}
-        Wait Until Page Contains Element    css:div.lsp-statusbar-item
-        Wait For Condition
-        ...    return document.querySelector('div.lsp-statusbar-item').textContent.includes('Fully initialized') || document.querySelector('.jp-Dialog') !== null;
-        ...    timeout=180s
-    ELSE
-        Wait For Dialog
-    END
-    ${count} =    Get Element Count    ${DIALOG WINDOW}
-    IF    ${count} != 0    Accept Default Dialog Option
     IF    ${wait}    Wait Until Fully Initialized
     Capture Page Screenshot    01-notebook-initialized.png
 

atest/Variables.resource

@@ -29,8 +29,8 @@ ${CSS DIALOG OK}                css:.jp-Dialog .jp-mod-accept
 ${MENU OPEN WITH}               xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "Open With")]
 # R is missing on purpose (may need to use .)
 ${MENU RENAME}                  xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(., "ename")]
-# N is missing on purpose
-${MENU NOTEBOOK}                xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(., "otebook")]
+# N is missing on purpose (N is in separate <span>)
+${MENU NOTEBOOK}                xpath://li[@data-command='filebrowser:open']/div[contains(@class, 'lm-Menu-itemLabel')][contains(., "otebook")]
 ${DIAGNOSTICS PANEL}            id:lsp-diagnostics-panel
 ${DIAGNOSTIC PANEL CLOSE}       css:.lm-DockPanel-tabBar .lm-TabBar-tab[data-id="lsp-diagnostics-panel"] .lm-TabBar-tabCloseIcon
 ${DIALOG WINDOW}                css:.jp-Dialog