try to only look at log once

Author: bollwyvl

atest/03_Notebook.robot

@@ -1,6 +1,6 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    notebook
-Test Setup        Run Keywords    Capture Lab Log Before Test    Try to Close All Tabs
+Test Setup        Try to Close All Tabs
 Resource          Keywords.robot
 
 *** Test Cases ***

atest/04_Interface/DiagnosticsPanel.robot

@@ -1,7 +1,7 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    diagnostics_panel
 Resource          ../Keywords.robot
-Test Setup        Run Keywords    Capture Lab Log Before Test    Gently Reset Workspace
+Test Setup        Gently Reset Workspace
 
 *** Variables ***
 ${EXPECTED_COUNT}    1

atest/05_Features/Completion.robot

@@ -93,7 +93,6 @@ Triggers Completer On Dot
 
 *** Keywords ***
 Setup Completion Test
-    Capture Lab Log Before Test
     Setup Notebook    Python    Completion.ipynb
 
 Get Cell Editor Content

atest/Keywords.robot

@@ -23,7 +23,7 @@ Setup Server and Browser
     ${cmd} =    Create Lab Launch Command    ${root}
     Set Screenshot Directory    ${OUTPUT DIR}${/}screenshots
     Set Global Variable    ${LAB LOG}    ${OUTPUT DIR}${/}lab.log
-    Set Global Variable    ${PREVIOUS LAB LOG TEXT}    ${EMPTY}
+    Set Global Variable    ${PREVIOUS LAB LOG LENGTH}    0
     ${server} =    Start Process    ${cmd}    shell=yes    env:HOME=${home}    cwd=${home}    stdout=${LAB LOG}
     ...    stderr=STDOUT
     Set Global Variable    ${SERVER}    ${server}
@@ -67,14 +67,11 @@ Tear Down Everything
     Terminate All Processes
     Terminate All Processes    kill=${True}
 
-Capture Lab Log Before Test
+Lab Log Should Not Contain Known Error Messages
     ${log} =    Get File    ${LAB LOG}
+    ${test log} =    Set Variable    ${log[${PREVIOUS LAB LOG LENGTH}:]}
     ${length} =    Get Length    ${log}
     Set Global Variable    ${PREVIOUS LAB LOG LENGTH}    ${length}
-
-Lab Log Should Not Contain Known Error Messages
-    ${log} =    Get File    ${LAB LOG}
-    ${test log} =    Set Variable    ${log[:${PREVIOUS LAB LOG LENGTH}]}
     Should Not Contain Any    ${test log}    @{KNOWN BAD ERRORS}    msg=${test log}
 
 Wait For Splash

atest/__init__.robot

@@ -1,7 +1,7 @@
 *** Settings ***
 Suite Setup       Setup Server and Browser
 Suite Teardown    Tear Down Everything
-Test Setup        Run Keywords    Capture Lab Log Before Test    Reset Application State
+Test Setup        Reset Application State
 Test Teardown     Lab Log Should Not Contain Known Error Messages
 Force Tags        os:${OS.lower()}    py:${PY}
 Resource          Keywords.robot