Lint typescript changes

Author: krassowski

packages/jupyterlab-lsp/src/adapters/codemirror/cm_adapter.spec.ts

@@ -7,16 +7,8 @@ import {
 } from '../jupyterlab/jl_adapter';
 import { IRootPosition } from '../../positioning';
 import * as CodeMirror from 'codemirror';
-import { CodeMirrorLSPFeature, IFeatureSettings } from './feature';
-import { FileEditorFeatureTestEnvironment } from './testutils';
-
-export class DummySettings implements IFeatureSettings {
-  get(setting: string): any {
-  }
-
-  set(setting: string, value: any): void {
-  }
-}
+import { CodeMirrorLSPFeature } from './feature';
+import { DummySettings, FileEditorFeatureTestEnvironment } from './testutils';
 
 describe('CodeMirrorAdapter', () => {
   let env: FileEditorFeatureTestEnvironment;

packages/jupyterlab-lsp/src/adapters/codemirror/feature.spec.ts

@@ -8,6 +8,7 @@ import {
 import { CodeMirrorLSPFeature } from './feature';
 import {
   code_cell,
+  DummySettings,
   FeatureTestEnvironment,
   FileEditorFeatureTestEnvironment,
   getCellsJSON,
@@ -22,7 +23,6 @@ import { language_specific_overrides } from '../../magics/defaults';
 import { foreign_code_extractors } from '../../extractors/defaults';
 import { NotebookModel } from '@jupyterlab/notebook';
 import { PageConfig } from '@jupyterlab/coreutils';
-import { DummySettings } from "./cm_adapter.spec";
 
 const js_fib_code = `function fib(n) {
   return n<2?n:fib(n-1)+fib(n-2);

packages/jupyterlab-lsp/src/adapters/codemirror/features/completion.ts

@@ -23,10 +23,14 @@ export class Completion extends CodeMirrorLSPFeature {
   afterChange(change: CodeMirror.EditorChange): void {
     // TODO: maybe the completer could be kicked off in the handleChange() method directly; signature help still
     //  requires an up-to-date virtual document on the LSP side, so we need to wait for sync.
-    if (change.text && change.text[0].length == 1 && this.settings.get('continuousHinting') as boolean) {
+    if (
+      change.text &&
+      change.text[0].length == 1 &&
+      (this.settings.get('continuousHinting') as boolean)
+    ) {
       this.jupyterlab_components.invoke_completer(
         CompletionTriggerKind.Invoked
-      )
+      );
       return;
     }
 

packages/jupyterlab-lsp/src/adapters/codemirror/testutils.ts

@@ -3,7 +3,11 @@ import {
   CodeMirrorEditorFactory
 } from '@jupyterlab/codemirror';
 import { VirtualEditor } from '../../virtual/editor';
-import { CodeMirrorLSPFeature, ILSPFeatureConstructor } from './feature';
+import {
+  CodeMirrorLSPFeature,
+  IFeatureSettings,
+  ILSPFeatureConstructor
+} from './feature';
 import { LSPConnection } from '../../connection';
 import { CodeEditor } from '@jupyterlab/codeeditor';
 import { VirtualFileEditor } from '../../virtual/editors/file_editor';
@@ -19,11 +23,11 @@ import { IOverridesRegistry } from '../../magics/overrides';
 import { IForeignCodeExtractorsRegistry } from '../../extractors/types';
 import * as nbformat from '@jupyterlab/nbformat';
 import { ICellModel } from '@jupyterlab/cells';
-import createNotebook = NBTestUtils.createNotebook;
 import { CodeMirrorAdapter } from './cm_adapter';
 import { VirtualDocument } from '../../virtual/document';
 import { LanguageServerManager } from '../../manager';
 import { DocumentConnectionManager } from '../../connection_manager';
+import createNotebook = NBTestUtils.createNotebook;
 
 interface IFeatureTestEnvironment {
   host: HTMLElement;
@@ -276,3 +280,13 @@ export async function synchronize_content(
     console.warn(e);
   }
 }
+
+export class DummySettings implements IFeatureSettings {
+  get(setting: string): any {
+    return null;
+  }
+
+  set(setting: string, value: any): void {
+    return;
+  }
+}

packages/jupyterlab-lsp/src/adapters/jupyterlab/components/completion.ts

@@ -21,7 +21,7 @@ import { LSPConnection } from '../../../connection';
 import { Session } from '@jupyterlab/services';
 import ICompletionItemsResponseType = CompletionHandler.ICompletionItemsResponseType;
 import { kernelIcon } from '@jupyterlab/ui-components';
-import { IFeatureSettings } from "../../codemirror/feature";
+import { IFeatureSettings } from '../../codemirror/feature';
 
 /**
  * A LSP connector for completion handlers.
@@ -42,11 +42,11 @@ export class LSPConnector
   private trigger_kind: CompletionTriggerKind;
 
   private get suppress_auto_invoke_in(): string[] {
-    return this.options.settings.get("suppressInvokeIn")
+    return this.options.settings.get('suppressInvokeIn');
   }
 
   private get should_show_documentation(): boolean {
-    return this.options.settings.get("showDocumentation")
+    return this.options.settings.get('showDocumentation');
   }
 
   /**
@@ -227,11 +227,11 @@ export class LSPConnector
         label: match.label,
         insertText: match.insertText,
         type: match.kind ? completionItemKindNames[match.kind] : '',
-        documentation: show_documentation ? (
-          lsProtocol.MarkupContent.is(match.documentation)
-          ? match.documentation.value
-          : match.documentation
-        ) : null,
+        documentation: show_documentation
+          ? lsProtocol.MarkupContent.is(match.documentation)
+            ? match.documentation.value
+            : match.documentation
+          : null,
         filterText: match.filterText,
         deprecated: match.deprecated,
         data: { ...match }

packages/jupyterlab-lsp/src/adapters/jupyterlab/file_editor.ts

@@ -7,7 +7,7 @@ import { CodeMirrorEditor } from '@jupyterlab/codemirror';
 import { LSPConnector } from './components/completion';
 import { CodeEditor } from '@jupyterlab/codeeditor';
 import { VirtualFileEditor } from '../../virtual/editors/file_editor';
-import { LSPExtension } from "../../index";
+import { LSPExtension } from '../../index';
 
 export class FileEditorAdapter extends JupyterLabWidgetAdapter {
   editor: FileEditor;
@@ -45,11 +45,7 @@ export class FileEditorAdapter extends JupyterLabWidgetAdapter {
     editor_widget: IDocumentWidget<FileEditor>,
     jumper: FileEditorJumper
   ) {
-    super(
-      extension,
-      editor_widget,
-      'completer:invoke-file',
-    );
+    super(extension, editor_widget, 'completer:invoke-file');
     this.jumper = jumper;
     this.editor = editor_widget.content;
 
@@ -77,7 +73,7 @@ export class FileEditorAdapter extends JupyterLabWidgetAdapter {
       editor: this.editor.editor,
       connections: this.connection_manager.connections,
       virtual_editor: this.virtual_editor,
-      settings: this.completion_settings,
+      settings: this.completion_settings
     });
     this.extension.completion_manager.register({
       connector: this.current_completion_connector,

packages/jupyterlab-lsp/src/adapters/jupyterlab/jl_adapter.ts

@@ -22,7 +22,11 @@ import { Diagnostics } from '../codemirror/features/diagnostics';
 import { Highlights } from '../codemirror/features/highlights';
 import { Hover } from '../codemirror/features/hover';
 import { Signature } from '../codemirror/features/signature';
-import { ILSPFeatureConstructor, ILSPFeature, IFeatureSettings } from '../codemirror/feature';
+import {
+  ILSPFeatureConstructor,
+  ILSPFeature,
+  IFeatureSettings
+} from '../codemirror/feature';
 import { JumpToDefinition } from '../codemirror/features/jump_to';
 import { ICommandContext } from '../../command_manager';
 import { JSONObject } from '@lumino/coreutils';
@@ -32,22 +36,25 @@ import {
   ISocketConnectionOptions
 } from '../../connection_manager';
 import { Rename } from '../codemirror/features/rename';
-import { LSPExtension } from "../../index";
-import { ISettingRegistry } from "@jupyterlab/settingregistry";
-
+import { LSPExtension } from '../../index';
+import { ISettingRegistry } from '@jupyterlab/settingregistry';
 
 class LabFeatureSettings implements IFeatureSettings {
-
   private key = 'features';
 
-  constructor(private extension: LSPExtension, protected feature_name: string) {}
+  constructor(
+    private extension: LSPExtension,
+    protected feature_name: string
+  ) {}
 
   protected get lab_settings(): ISettingRegistry.ISettings {
     return this.extension.settings;
   }
 
   protected get_obj(): any {
-    return (this.lab_settings.get(this.key).composite as any)[this.feature_name.toLowerCase()];
+    return (this.lab_settings.get(this.key).composite as any)[
+      this.feature_name.toLowerCase()
+    ];
   }
 
   get(setting: string) {
@@ -57,11 +64,10 @@ class LabFeatureSettings implements IFeatureSettings {
   set(setting: string, value: any) {
     let obj = this.get_obj();
     obj[setting] = value;
-    this.lab_settings.set(this.key, obj).catch(console.warn)
+    this.lab_settings.set(this.key, obj).catch(console.warn);
   }
 }
 
-
 export const lsp_features: Array<ILSPFeatureConstructor> = [
   Completion,
   Diagnostics,
@@ -160,7 +166,7 @@ export abstract class JupyterLabWidgetAdapter
   protected constructor(
     protected extension: LSPExtension,
     protected widget: IDocumentWidget,
-    invoke: string,
+    invoke: string
   ) {
     this.app = extension.app;
     this.rendermime_registry = extension.rendermime_registry;
@@ -169,7 +175,10 @@ export abstract class JupyterLabWidgetAdapter
     this.invoke_command = invoke;
     this.adapters = new Map();
     this.status_message = new StatusMessage();
-    this.completion_settings = new LabFeatureSettings(this.extension, 'completion')
+    this.completion_settings = new LabFeatureSettings(
+      this.extension,
+      'completion'
+    );
 
     // set up signal connections
     this.widget.context.saveState.connect(this.on_save_state, this);

packages/jupyterlab-lsp/src/adapters/jupyterlab/notebook.ts

@@ -14,7 +14,7 @@ import * as nbformat from '@jupyterlab/nbformat';
 import ILanguageInfoMetadata = nbformat.ILanguageInfoMetadata;
 import { Session } from '@jupyterlab/services';
 import { SessionContext } from '@jupyterlab/apputils';
-import { LSPExtension } from "../../index";
+import { LSPExtension } from '../../index';
 
 export class NotebookAdapter extends JupyterLabWidgetAdapter {
   editor: Notebook;
@@ -31,11 +31,7 @@ export class NotebookAdapter extends JupyterLabWidgetAdapter {
     editor_widget: NotebookPanel,
     jumper: NotebookJumper
   ) {
-    super(
-      extension,
-      editor_widget,
-      'completer:invoke-notebook',
-    );
+    super(extension, editor_widget, 'completer:invoke-notebook');
     this.editor = editor_widget.content;
     this.jumper = jumper;
     this.init_once_ready().catch(console.warn);

packages/jupyterlab-lsp/src/index.ts

@@ -121,11 +121,7 @@ export class LSPExtension {
 
       if (fileEditor.editor instanceof CodeMirrorEditor) {
         let jumper = new FileEditorJumper(widget, documentManager);
-        let adapter = new FileEditorAdapter(
-          this,
-          widget,
-          jumper,
-        );
+        let adapter = new FileEditorAdapter(this, widget, jumper);
         file_editor_adapters.set(fileEditor.id, adapter);
 
         const disconnect = () => {
@@ -165,11 +161,7 @@ export class LSPExtension {
     const connect_notebook = (widget: NotebookPanel) => {
       // NOTE: assuming that the default cells content factory produces CodeMirror editors(!)
       let jumper = new NotebookJumper(widget, documentManager);
-      let adapter = new NotebookAdapter(
-        this,
-        widget,
-        jumper,
-      );
+      let adapter = new NotebookAdapter(this, widget, jumper);
       notebook_adapters.set(widget.id, adapter);
 
       const disconnect = () => {
@@ -222,9 +214,11 @@ export class LSPExtension {
 
       const languageServerSettings = (options.language_servers ||
         {}) as TLanguageServerConfigurations;
-      this.connection_manager.updateServerConfigurations(languageServerSettings);
+      this.connection_manager.updateServerConfigurations(
+        languageServerSettings
+      );
       this.settings = settings;
-    }
+    };
 
     this.setting_registry
       .load(plugin.id)
@@ -243,7 +237,6 @@ export class LSPExtension {
         console.error(reason.message);
       });
   }
-
 }
 
 /**
@@ -264,18 +257,21 @@ const plugin: JupyterFrontEndPlugin<void> = {
     IStatusBar
   ],
   activate: (app, ...args) => {
-    new LSPExtension(app, ...args as [
-      IEditorTracker,
-      INotebookTracker,
-      ISettingRegistry,
-      ICommandPalette,
-      IDocumentManager,
-      ICompletionManager,
-      IRenderMimeRegistry,
-      IPaths,
-      ILabShell,
-      IStatusBar
-    ]);
+    new LSPExtension(
+      app,
+      ...(args as [
+        IEditorTracker,
+        INotebookTracker,
+        ISettingRegistry,
+        ICommandPalette,
+        IDocumentManager,
+        ICompletionManager,
+        IRenderMimeRegistry,
+        IPaths,
+        ILabShell,
+        IStatusBar
+      ])
+    );
   },
   autoStart: true
 };