Enable noImplicitReturns

Author: krassowski

packages/jupyterlab-lsp/src/adapters/adapter.ts

@@ -647,6 +647,8 @@ export abstract class WidgetAdapter<T extends IDocumentWidget> {
         connection,
         virtual_document
       };
+    } else {
+      return undefined;
     }
   }
 

packages/jupyterlab-lsp/src/editor_integration/editor_adapter.ts

@@ -88,6 +88,7 @@ export class EditorAdapter<T extends IVirtualEditor<IEditor>> {
       this.console.error(e);
     }
     this.invalidateLastChange();
+    return undefined;
   }
 
   public invalidateLastChange() {

packages/jupyterlab-lsp/src/features/diagnostics/diagnostics.ts

@@ -106,6 +106,7 @@ class DiagnosticsPanel {
           return column;
         }
       }
+      return undefined;
     };
 
     /** Columns Menu **/

packages/jupyterlab-lsp/src/features/hover.ts

@@ -494,6 +494,7 @@ export class HoverCM extends CodeMirrorIntegration {
       ) {
         this.console.warn(e);
       }
+      return undefined;
     }
   };
 

packages/jupyterlab-lsp/src/features/jump_to.ts

@@ -94,7 +94,7 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
 
   get_uri_and_range(location_or_locations: AnyLocation) {
     if (location_or_locations == null) {
-      return;
+      return undefined;
     }
     // some language servers appear to return a single object
     const locations = Array.isArray(location_or_locations)
@@ -105,7 +105,7 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
     //  (like when there are multiple definitions or usages)
     //  could use the showHints() or completion frontend as a reference
     if (locations.length === 0) {
-      return;
+      return undefined;
     }
 
     this.console.log(
@@ -125,6 +125,12 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
         uri: location_or_link.uri,
         range: location_or_link.range
       };
+    } else {
+      this.console.warn(
+        'Returned jump location is incorrect (no uri or targetUri):',
+        location_or_link
+      );
+      return undefined;
     }
   }
 

packages/tsconfigbase.json

@@ -21,6 +21,7 @@
     "strictBindCallApply": true,
     "allowUnusedLabels": false,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitReturns": true,
     "types": []
   }
 }