Merge pull request #367 from krassowski/fix-pip-install-in-docs

krassowski · web-flow · commit 1c2b79b2c436 · 2020-09-16T22:19:10.000+01:00
Fix pip install version pin using = rather than ==
diff --git a/docs/Installation.ipynb b/docs/Installation.ipynb
@@ -271,7 +271,7 @@
     "##### pip\n",
     "\n",
     "```bash\n",
-    "pip install jupyter-lsp={JUPYTER_LSP_VERSION}\n",
+    "pip install jupyter-lsp=={JUPYTER_LSP_VERSION}\n",
     "jupyter labextension install @krassowski/jupyterlab-lsp@{JUPYTERLAB_LSP_VERSION}\n",
     "```"
    ]
diff --git a/scripts/integrity.py b/scripts/integrity.py
@@ -184,7 +184,8 @@ def test_changelog_versions(pkg, version):
 @pytest.mark.parametrize(
     "pkg,sep,version,expected",
     [
-        [PY_NAME, "=", PY_VERSION, 3],
+        [PY_NAME, "=", PY_VERSION, 2],
+        [PY_NAME, "==", PY_VERSION, 1],
         [PY_NAME + "-python", "=", PY_VERSION, 1],
         [JS_LSP_NAME, "@", JS_LSP_VERSION, 4]
     ],

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@`
`271`	`271`	`"##### pip\n",`
`272`	`272`	`"\n",`
`273`	`273`	"```bash\n",
`274`		`- "pip install jupyter-lsp={JUPYTER_LSP_VERSION}\n",`
	`274`	`+ "pip install jupyter-lsp=={JUPYTER_LSP_VERSION}\n",`
`275`	`275`	`"jupyter labextension install @krassowski/jupyterlab-lsp@{JUPYTERLAB_LSP_VERSION}\n",`
`276`	`276`	"```"
`277`	`277`	`]`