Merge branch 'master' into add-i18n

Author: krassowski

.github/pull_request_template.md

@@ -7,7 +7,8 @@ https://github.com/jupyterlab/jupyterlab/blob/master/CONTRIBUTING.md
 
 ## References
 
-<!-- Note issue numbers this pull request addresses (should be at least one, see contributing guidelines above). -->
+<!-- Note issue numbers this pull request addresses (should be at least one, see contributing guidelines above).
+Use "fixes" and "closes" linking phrases as appropriate. -->
 
 <!-- Note any other pull requests that address this issue and how this pull request is different. -->
 
@@ -27,7 +28,7 @@ https://github.com/jupyterlab/jupyterlab/blob/master/CONTRIBUTING.md
 
 ## Chores
 
-- [ ] linted
-- [ ] tested
-- [ ] documented
-- [ ] changelog entry
+- [ ] linted <!-- Required: Run "jlpm lint" and "python scripts/lint.py" from the root of the repository, then check this box like this: [x] -->
+- [ ] tested <!-- Recommended: Let us know if you already added a test case (if relevant). -->
+- [ ] documented <!-- Optional: Would it be good to improve the documentation? If yes, please consider doing this and checking this box. -->
+- [ ] changelog entry <!-- Recommended: Add a note in the CHANGELOG.md file under the most recent >unreleased< version; if one does not exist, feel free to create one by increasing the version number (no worries if you are not certain of the details - we can improve it later; let's just have something to work with) -->

.github/workflows/job.test.yml

@@ -16,17 +16,17 @@ defaults:
     shell: bash -l {0}
 
 env:
-  # Increase this value to reset all caches
-  CACHE_EPOCH: 0
-
-  JLPM_CMD: jlpm --ignore-optional --prefer-offline --frozen-lockfile
-
+  JULIA_NUM_THREADS: 2
+  MAMBA_NO_BANNER: 1
+  PIP_DISABLE_PIP_VERSION_CHECK: 1
   PYTHONUNBUFFERED: 1
+
   ATEST_RETRIES: 3
-  PIP_DISABLE_PIP_VERSION_CHECK: 1
+  JLPM_CMD: jlpm --ignore-optional --prefer-offline --frozen-lockfile
 
-  # TODO: replace once mambaforge "just works" with setup-miniconda
-  MAMBAFORGE_URL: https://github.com/conda-forge/miniforge/releases/latest/download/Mambaforge
+  # Increase this value to reset all caches
+  CACHE_EPOCH: 2
+  JULIA_LANGSERVER: 3.2.0
 
 jobs:
   lint:
@@ -50,7 +50,7 @@ jobs:
           nodejs: '${{ matrix.nodejs }}'
 
       - name: Cache conda
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: ~/conda_pkgs_dir
           key: |
@@ -61,11 +61,9 @@ jobs:
       - name: Set up Python and mamba
         uses: conda-incubator/setup-miniconda@v2
         with:
-          installer-url: ${{ env.MAMBAFORGE_URL }}-Linux-x86_64.sh
-          condarc-file: .github/.condarc
-
-      - name: Install base conda dependencies
-        run: mamba env update -n test --file requirements/github-actions.yml
+          environment-file: requirements/github-actions.yml
+          miniforge-variant: Mambaforge
+          use-mamba: true
 
       - name: Install linting dependencies
         run: mamba env update -n test --file requirements/lint.yml
@@ -78,15 +76,17 @@ jobs:
         uses: actions/cache@v2
         with:
           path: '**/node_modules'
-          key: ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-lint-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-lint-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
 
       - name: Cache yarn packages
         id: cache-yarn-packages
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: .yarn-packages
-          key: ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
           restore-keys: |
             ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-
             ${{ env.CACHE_EPOCH }}-yarn-
@@ -107,6 +107,9 @@ jobs:
       - name: Lint frontend
         run: jlpm lint:check
 
+      - name: Check distributions
+        run: python scripts/distcheck.py
+
   build:
     name: build
     runs-on: ${{ matrix.os }}
@@ -128,7 +131,7 @@ jobs:
           nodejs: '${{ matrix.nodejs }}'
 
       - name: Cache conda
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: ~/conda_pkgs_dir
           key: |
@@ -139,8 +142,7 @@ jobs:
       - name: Set up Python and mamba
         uses: conda-incubator/setup-miniconda@v2
         with:
-          installer-url: ${{ env.MAMBAFORGE_URL }}-Linux-x86_64.sh
-          condarc-file: .github/.condarc
+          miniforge-variant: Mambaforge
 
       - name: Install minimal build deps
         shell: bash -l {0}
@@ -151,15 +153,17 @@ jobs:
         uses: actions/cache@v2
         with:
           path: '**/node_modules'
-          key: ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-build-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-build-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
 
       - name: Cache yarn packages
         id: cache-yarn-packages
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: .yarn-packages
-          key: ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
           restore-keys: |
             ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-
             ${{ env.CACHE_EPOCH }}-yarn-
@@ -230,11 +234,6 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - uses: julia-actions/setup-julia@v1
-
-      - name: Install Julia language server
-        run: julia -e 'using Pkg; Pkg.add("LanguageServer")'
-
       - name: Set JupyterLab and Node versions
         uses: cschleiden/replace-tokens@v1
         with:
@@ -246,7 +245,7 @@ jobs:
           nodejs: '${{ matrix.nodejs }}'
 
       - name: Cache conda
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: ~/conda_pkgs_dir
           key: |
@@ -257,24 +256,9 @@ jobs:
       - name: Set up Python and mamba
         uses: conda-incubator/setup-miniconda@v2
         with:
-          installer-url: ${{ env.MAMBAFORGE_URL }}-${{ matrix.mambaforge }}
-          python-version: ${{ matrix.python }}
-          condarc-file: .github/.condarc
-
-      - name: Describe conda
-        run: |
-          conda info
-          conda config --show-sources
-          conda config --show
-
-      - name: Install conda dependencies (unix)
-        if: ${{ matrix.os != 'windows' }}
-        run: mamba env update -n test --file requirements/github-actions.yml
-
-      - name: Install conda dependencies (windows)
-        if: ${{ matrix.os == 'windows' }}
-        shell: cmd /C call {0}
-        run: mamba env update -n test --file requirements/github-actions.yml
+          environment-file: requirements/github-actions.yml
+          miniforge-variant: Mambaforge
+          use-mamba: true
 
       - name: List all packages
         run: conda list
@@ -284,22 +268,26 @@ jobs:
         uses: actions/cache@v2
         with:
           path: '**/node_modules'
-          key: ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-test-${{ hashFiles('yarn.lock', 'requirements/github-actions.yml') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-${{ runner.os }}-node-atest-${{ hashFiles('yarn.lock') }}
 
       - name: Cache yarn packages
         id: cache-yarn-packages
         if: steps.cache-node-modules.outputs.cache-hit != 'true'
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: .yarn-packages
-          key: ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
+          key: |
+            ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
           restore-keys: |
             ${{ env.CACHE_EPOCH }}-yarn-${{ runner.os }}-
             ${{ env.CACHE_EPOCH }}-yarn-
 
-      - name: install npm dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
-        run: ${{ env.JLPM_CMD }}
+      - uses: actions/cache@v2
+        with:
+          path: ~/.julia/artifacts
+          key: |
+            ${{ env.CACHE_EPOCH }}-julia-test-${{ runner.os }}-${{ env.JULIA_LANGSERVER }}
 
       - uses: actions/download-artifact@v2
         with:
@@ -325,6 +313,16 @@ jobs:
       - name: List frontend extensions
         run: jupyter labextension list
 
+      - name: install node-based language servers
+        if: steps.cache-node-modules.outputs.cache-hit != 'true'
+        run: ${{ env.JLPM_CMD }}
+
+      - name: Install Julia
+        uses: julia-actions/setup-julia@v1
+
+      - name: Install Julia language server
+        run: julia -e 'using Pkg; Pkg.add(Pkg.PackageSpec(;name="LanguageServer", version="${{ env.JULIA_LANGSERVER }}"))'
+
       - name: Run python tests
         run: python scripts/utest.py
 

CHANGELOG.md

@@ -1,14 +1,41 @@
 ## CHANGELOG
 
-### `@krassowski/jupyterlab-lsp 3.4.2` (unreleased)
+### `@krassowski/jupyterlab-lsp 3.5.1` (unreleased)
+
+- bug fixes:
+
+  - fixes name of jupyterlab-lsp package displayed in JupyterLab UI ([#570])
+  - remove vendored CodeMirror from distribution ([#576])
+
+[#570]: https://github.com/krassowski/jupyterlab-lsp/pull/570
+[#576]: https://github.com/krassowski/jupyterlab-lsp/pull/576
+
+### `@krassowski/jupyterlab-lsp 3.5.0` (2020-03-22)
+
+- features:
+
+  - adds `%%bigquery` IPython cell magic support for BigQuery ([#553], thanks @julioyildo)
+  - completions filtering can be set to case-insensitive in settings ([#549])
+  - completions filtering can hide exact matches ([#549])
+  - the extra information displayed next to the completion label now can include 'detail' (usually module/package of origin), and can be customized in settings ([#549])
 
 - bug fixes:
 
   - prevents throwing a highlights error when adding new cell with <kbd>Shift</kbd> + <kbd>Enter</kbd> ([#544])
   - fixes IPython `pinfo` and `pinfo2` (`?` and `??`) for identifiers containing `s` ([#547])
+  - fixes incorrect behaviour of LSP features in some IPython magics with single line of content ([#560])
+  - fixes name of jupyterlab-lsp package in JupyterLab
+
+- for extension authors:
+
+  - minimal functional extractor and code overrides APIs are now exported; these APIs cab be subject to change in future releases ([#562])
 
 [#544]: https://github.com/krassowski/jupyterlab-lsp/pull/544
 [#547]: https://github.com/krassowski/jupyterlab-lsp/pull/547
+[#549]: https://github.com/krassowski/jupyterlab-lsp/pull/549
+[#553]: https://github.com/krassowski/jupyterlab-lsp/pull/553
+[#560]: https://github.com/krassowski/jupyterlab-lsp/pull/560
+[#562]: https://github.com/krassowski/jupyterlab-lsp/pull/562
 
 ### `jupyter-lsp 1.1.4` (2020-02-21)
 

CONTRIBUTING.md

@@ -126,6 +126,12 @@ To run tests matching specific phrase, forward `-t` argument over yarn and lerna
 jlpm test -- -- -t match_phrase
 ```
 
+To verify the webpack build wouldn't include problematic vendored dependencies:
+
+```bash
+python scripts/distcheck.py
+```
+
 ### Server Development
 
 #### Testing `jupyter-lsp`

atest/05_Features/Completion.robot

@@ -296,6 +296,28 @@ Shows Documentation With CompletionItem Resolve
     Completer Should Include Documentation    the default method of the
     [Teardown]    Clean Up After Working With File    completion.R
 
+Shows Only Relevant Suggestions In Known Magics
+    # https://github.com/krassowski/jupyterlab-lsp/issues/559
+    # h<tab>
+    Enter Cell Editor    20    line=2
+    Trigger Completer
+    Completer Should Suggest    help
+    Completer Should Not Suggest    from
+    Completer Should Suggest    hash
+
+Completes In R Magics
+    # Proper completion in R magics needs to be tested as:
+    # - R magic extractor uses a tailor-made replacer function, not tested elsewhere
+    # - R lanugage server is very sensitive to off-by-one errors (see https://github.com/REditorSupport/languageserver/issues/395)
+    # '%%R\n librar<tab>'
+    Enter Cell Editor    22    line=2
+    Trigger Completer
+    Completer Should Suggest    library
+    # '%R lib<tab>'
+    Enter Cell Editor    24    line=1
+    Trigger Completer
+    Completer Should Suggest    library
+
 *** Keywords ***
 Setup Completion Test
     Setup Notebook    Python    Completion.ipynb

atest/examples/Completion.ipynb

@@ -150,6 +150,56 @@
    "source": [
     "t"
    ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "Cell magics show only relevant suggestions (triggering after `h` should return `hash`, `help`, etc, but not `from`):"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "%%python\n",
+    "h"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "Test that the leading space does not cause issues in R cell magic:"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "%%R\n",
+    " librar"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "And that R line magic works too:"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "%R li"
+   ]
   }
  ],
  "metadata": {

docs/Installation.ipynb

@@ -250,7 +250,7 @@
     "##### pip\n",
     "\n",
     "```bash\n",
-    "pip install jupyterlab-lsp={JUPYTERLAB_LSP_VERSION}\n",
+    "pip install jupyterlab-lsp=={JUPYTERLAB_LSP_VERSION}\n",
     "```"
    ]
   },