Skip to content

Commit 26fb463

Browse files
committed
Rename options
1 parent 2dc4089 commit 26fb463

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ from the Language Server (in notebook).
6666
If the kernel is too slow to respond promptly only the Language Server suggestions will be shown (default threshold: 0.6s).
6767
You can configure the completer to not attempt to fetch the kernel completions if the kernel is busy (skipping the 0.6s timeout).
6868

69-
You can deactivate the kernel suggestions by adding `"kenel"` to the `disableCompletionsFrom` in the `completion` section
70-
of _Advanced Settings_. Alternatively if you _only_ want kernel completions you can add `"languageServer"` to the same
69+
You can deactivate the kernel suggestions by adding `"Kernel"` to the `disableCompletionsFrom` in the `completion` section
70+
of _Advanced Settings_. Alternatively if you _only_ want kernel completions you can add `"LSP"` to the same
7171
setting; Or add both if you like to code in hardcore mode and get no completions, or if another provider has been added.
7272

7373
### Rename

packages/jupyterlab-lsp/schema/completion.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"description": "The time to wait for the kernel completions suggestions in milliseconds. Set to 0 to disable kernel completions, or to -1 to wait indefinitely (not recommended)."
4343
},
4444
"disableCompletionsFrom": {
45-
"description": "The sources from which to exclude completion from. Possible values include 'kernel', 'languageServer'.",
45+
"description": "The sources from which to exclude completion from. Possible values include 'Kernel', 'LSP'.",
4646
"type": "array",
4747
"default": [],
4848
"uniqueItems": true

packages/jupyterlab-lsp/src/features/completion/completion_handler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,15 @@ export class LSPConnector
8181
protected get use_lsp_completions(): boolean {
8282
return (
8383
this.options.settings.composite.disableCompletionsFrom.indexOf(
84-
'languageServer'
84+
'LSP'
8585
) == -1
8686
);
8787
}
8888

8989
protected get use_kernel_completions(): boolean {
9090
return (
9191
this.options.settings.composite.disableCompletionsFrom.indexOf(
92-
'kernel'
92+
'Kernel'
9393
) == -1
9494
);
9595
}

0 commit comments

Comments
 (0)