Fix hiding of panel, fix illegal constructor for plain-text documentation

Author: krassowski

packages/jupyterlab-lsp/src/features/completion/completion.ts

@@ -261,18 +261,18 @@ export class CompletionLabIntegration implements IFeatureLabIntegration {
 
       docPanel.setAttribute('style', '');
     } else {
-      docPanel.setAttribute('style', 'none');
+      docPanel.setAttribute('style', 'display: none');
     }
   }
 
-  set_doc_panel_placeholder(enabled: boolean) {
+  set_doc_panel_placeholder(enable: boolean) {
     let completer = this.current_completion_handler.completer;
     const docPanel = completer.node.querySelector(DOC_PANEL_SELECTOR);
-    if (enabled) {
+    if (enable) {
       docPanel.setAttribute('style', '');
       docPanel.classList.add(DOC_PANEL_PLACEHOLDER_CLASS);
-    } else {
-      docPanel.setAttribute('style', 'none');
+    } else if (docPanel.classList.contains(DOC_PANEL_PLACEHOLDER_CLASS)) {
+      docPanel.setAttribute('style', 'display: none');
       docPanel.classList.remove(DOC_PANEL_PLACEHOLDER_CLASS);
     }
   }

packages/jupyterlab-lsp/src/features/completion/completion_handler.ts

@@ -130,12 +130,12 @@ export class LazyCompletionItem implements CompletionHandler.ICompletionItem {
     connection
       .getCompletionResolve(this.match)
       .then(resolvedCompletionItem => {
+        this.connector.lab_integration.set_doc_panel_placeholder(false);
         if (resolvedCompletionItem === null) {
           return;
         }
         this._setDocumentation(resolvedCompletionItem.documentation);
         this._resolved = true;
-        this.connector.lab_integration.set_doc_panel_placeholder(false);
         this.connector.lab_integration.refresh_doc_panel(this);
       })
       .catch(e => {

packages/jupyterlab-lsp/src/features/completion/renderer.ts

@@ -66,7 +66,7 @@ export class LSPCompletionRenderer
         .catch(this.options.console.warn);
       return this.options.markdownRenderer.node;
     } else {
-      let node = new HTMLDivElement();
+      let node = document.createElement('div');
       node.textContent = item.documentation;
       return node;
     }