Convert settings to allow vscode-style setting strings

Author: trajamsmith

package.json

@@ -1,5 +1,6 @@
 {
   "dependencies": {
+    "lodash": "^4.17.15"
   },
   "devDependencies": {
     "bash-language-server": "^1.6.1",
@@ -12,10 +13,10 @@
     "lerna": "^3.13.2",
     "precise-commits": "^1.0.2",
     "prettier": "^1.19.1",
+    "tslint": "^5.15.0",
     "tslint-config-prettier": "^1.18.0",
     "tslint-plugin-prettier": "^2.0.1",
     "tslint-react": "^4.0.0",
-    "tslint": "^5.15.0",
     "typescript": "~3.7.2",
     "unified-language-server": "^0.3.0",
     "vscode-css-languageserver-bin": "^1.4.0",

packages/jupyterlab-lsp/schema/plugin.json

@@ -24,12 +24,12 @@
       "description": "Client and server configurations for a single language server",
       "type": "object",
       "default": {},
-      "properties": {
-        "settings": {
-          "title": "Language Server Settings",
-          "description": "Configuration to be sent to language server over LSP when initialized: see the specific language server's documentation for more",
-          "type": "object",
-          "default": {}
+      "patternProperties": {
+        "^.*$": {
+          "anyOf": [
+            {"type": "string"},
+            {"type": "boolean"}
+          ]
         }
       }
     }

packages/jupyterlab-lsp/src/connection_manager.ts

@@ -3,7 +3,7 @@ import { LSPConnection } from './connection';
 
 import { Signal } from '@lumino/signaling';
 import { PageConfig, URLExt } from '@jupyterlab/coreutils';
-import { sleep, until_ready } from './utils';
+import { sleep, until_ready, vscodeStyleSettingsParser } from './utils';
 
 // Name-only import so as to not trigger inclusion in main bundle
 import * as ConnectionModuleType from './connection';
@@ -157,9 +157,14 @@ export class DocumentConnectionManager {
     lsSettings: any
   ) {
     for (let language_server_id in lsSettings) {
+      const parsedSettings = vscodeStyleSettingsParser(
+        lsSettings[language_server_id]
+      );
+
       const serverSettings: ILanguageServerConfiguration = {
-        settings: lsSettings
+        settings: parsedSettings
       };
+
       Private.updateServerConfiguration(language_server_id, serverSettings);
     }
   }
@@ -394,6 +399,9 @@ namespace Private {
     language_server_id: TLanguageServerId,
     settings: ILanguageServerConfiguration
   ): void {
+    console.log('Server Update: ', language_server_id);
+    console.log('Sending settings: ', settings);
+
     const connection = _connections.get(language_server_id);
     if (connection) {
       connection.sendConfigurationChange(settings);

packages/jupyterlab-lsp/src/utils.ts

@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import { PageConfig } from '@jupyterlab/coreutils';
 
 const RE_PATH_ANCHOR = /^file:\/\/([^\/]+|\/[A-Z]:)/;
@@ -130,3 +131,37 @@ export function uri_to_contents_path(child: string, parent?: string) {
   }
   return null;
 }
+
+/**
+ * The docs for many language servers show settings in the
+ * VSCode format, e.g.: "pyls.plugins.pyflakes.enabled"
+ *
+ * VSCode converts that dot notation to JSON behind the scenes,
+ * as the language servers themselves don't accept that syntax.
+ */
+const vscodeStyleSettingParser = (settingString: string, value: any) => {
+  const propArr: any = settingString.split('.');
+  const obj: any = {};
+
+  let curr = obj;
+  propArr.forEach((prop: string, i: any) => {
+    curr[prop] = {};
+
+    if (i === propArr.length - 1) {
+      curr[prop] = value;
+    } else {
+      curr = curr[prop];
+    }
+  });
+
+  return obj;
+};
+
+export const vscodeStyleSettingsParser = (settingsObject: any) => {
+  const settings: any = [];
+  for (let setting in settingsObject) {
+    const parsed = vscodeStyleSettingParser(setting, settingsObject[setting]);
+    settings.push(parsed);
+  }
+  return _.merge({}, ...settings);
+};