Skip to content

Commit 2da63e2

Browse files
committed
squash more warnings: setenv, osx
1 parent cf9e190 commit 2da63e2

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/job.test.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ jobs:
3535
# TODO: maybe turn back on
3636
fail-fast: false
3737
matrix:
38+
os: [ubuntu-latest, macos-latest, windows-latest]
3839
python: [3.6, 3.7, 3.8]
39-
os: [ubuntu-16.04, macos-10.14, vs2017-win2016]
4040
lab: ['>=2.2.0,<3.0.0a0']
4141
include:
4242
# if using 3.6, use an old node
@@ -118,12 +118,13 @@ jobs:
118118
run: cd dist && python -m pip install jupyter_lsp-${{ env.PY_JLSP_VERSION }}-py3-none-any.whl --no-deps
119119

120120
- name: Find out jedi cache location
121-
run: python -c 'import jedi; print("::set-env name=JEDI_CACHE_DIR::" + jedi.settings.cache_directory)'
121+
id: jedi-cache
122+
run: python -c 'import jedi; print("::set-output name=dir::" + jedi.settings.cache_directory)'
122123

123124
- name: Cache jedi cache
124125
uses: actions/cache@v1
125126
with:
126-
path: ${{ env.JEDI_CACHE_DIR }}
127+
path: ${{ steps.jedi-cache.outputs.dir }}
127128
key: jedi-${{ matrix.os }}-${{ hashFiles('scripts/jedi_cache.py') }}-${{ hashFiles('requirements/github-actions.yml') }}
128129

129130
- name: Warm up jedi cache
@@ -143,7 +144,7 @@ jobs:
143144
run: python scripts/tectonic_cache.py
144145

145146
- name: Run frontend unit tests
146-
if: ${{ !contains(matrix.os, 'win') }}
147+
if: ${{ !contains(matrix.os, 'windows') }}
147148
run: jlpm test
148149

149150
# js_cov_packages:

0 commit comments

Comments
 (0)