linting

Author: bollwyvl

atest/logcheck.py

@@ -1,5 +1,3 @@
-import os
-
 from bs4 import UnicodeDammit
 
 
@@ -13,12 +11,18 @@ def file_should_not_contain_phrases(filename, offset=0, *phrases):
     try:
         text = raw.decode("utf-8")
     except Exception as err:
-        text = UnicodeDammit.detwingle(raw).decode("utf-8")
+        print("Failed to read", filename, "forcing unicode...\n", err)
+        try:
+            text = UnicodeDammit.detwingle(raw).decode("utf-8")
+        except Exception as err:
+            print("Failed to read", filename, "giving up...\n", err)
+            text = None
 
     matches = {}
 
-    for phrase in phrases:
-        if phrase in text:
-            matches[phrase] = True
+    if text is not None:
+        for phrase in phrases:
+            if phrase in text:
+                matches[phrase] = True
 
-    assert not matches, "Phrases found in {}: {}".format(filename, matches)
+        assert not matches, "Phrases found in {}: {}".format(filename, matches)

package.json

@@ -51,7 +51,7 @@
     "lint:check": "jlpm prettier:check && jlpm eslint:check",
     "lint": "jlpm prettier && jlpm eslint",
     "prettier:check": "prettier --check \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md,.yml}\"",
-    "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md,.yml}\"",
+    "prettier": "prettier --list-different --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md,.yml}\"",
     "eslint": "eslint --config packages/.eslintrc.js --ext .js,.jsx,.ts,.tsx --fix packages",
     "eslint:check": "eslint --config packages/.eslintrc.js --ext .js,.jsx,.ts,.tsx packages",
     "test": "lerna run --stream --concurrency=1 test"

scripts/lint.py

@@ -60,7 +60,7 @@ def lint():
                 ["mypy", *PY_SRC],
                 ["python", "-m", "robot.tidy", "--inplace", *ALL_ROBOT],
                 ["rflint", *RFLINT, *ALL_ROBOT],
-                ["python", "scripts/atest.py", "--dryrun", "--console", "quiet"],
+                ["python", "scripts/atest.py", "--dryrun", "--console", "dotted"],
                 ["python", "scripts/nblint.py"],
             ],
         )