Move initializeParams which are fully responsibility of client,

and not the connection implementation detail

Author: krassowski

packages/jupyterlab-lsp/src/connection.ts

@@ -19,6 +19,7 @@ import type * as rpc from 'vscode-jsonrpc';
 import type * as lsp from 'vscode-languageserver-protocol';
 import type { MessageConnection } from 'vscode-ws-jsonrpc';
 
+import { CompletionItemTag } from './lsp';
 import { ILSPLogConsole } from './tokens';
 import { until_ready } from './utils';
 
@@ -392,6 +393,74 @@ export class LSPConnection extends LspWsConnection {
       );
   }
 
+  /**
+   * Initialization parameters to be sent to the language server.
+   * Subclasses can overload this when adding more features.
+   */
+  protected initializeParams(): lsp.InitializeParams {
+    return {
+      ...super.initializeParams(),
+      capabilities: {
+        textDocument: {
+          hover: {
+            dynamicRegistration: true,
+            contentFormat: ['markdown', 'plaintext']
+          },
+          synchronization: {
+            dynamicRegistration: true,
+            willSave: false,
+            didSave: true,
+            willSaveWaitUntil: false
+          },
+          completion: {
+            dynamicRegistration: true,
+            completionItem: {
+              snippetSupport: false,
+              commitCharactersSupport: true,
+              documentationFormat: ['markdown', 'plaintext'],
+              deprecatedSupport: true,
+              preselectSupport: false,
+              tagSupport: {
+                valueSet: [CompletionItemTag.Deprecated]
+              }
+            },
+            contextSupport: false
+          },
+          signatureHelp: {
+            dynamicRegistration: true,
+            signatureInformation: {
+              documentationFormat: ['markdown', 'plaintext']
+            }
+          },
+          declaration: {
+            dynamicRegistration: true,
+            linkSupport: true
+          },
+          definition: {
+            dynamicRegistration: true,
+            linkSupport: true
+          },
+          typeDefinition: {
+            dynamicRegistration: true,
+            linkSupport: true
+          },
+          implementation: {
+            dynamicRegistration: true,
+            linkSupport: true
+          }
+        } as lsp.ClientCapabilities,
+        workspace: {
+          didChangeConfiguration: {
+            dynamicRegistration: true
+          }
+        } as lsp.WorkspaceClientCapabilities
+      } as lsp.ClientCapabilities,
+      initializationOptions: null,
+      processId: null,
+      workspaceFolders: null
+    };
+  }
+
   sendOpenWhenReady(documentInfo: IDocumentInfo) {
     if (this.isReady) {
       this.sendOpen(documentInfo);

packages/jupyterlab-lsp/src/lsp.ts

@@ -10,6 +10,10 @@ export enum DiagnosticTag {
   Deprecated = 2
 }
 
+export enum CompletionItemTag {
+  Deprecated = 1
+}
+
 export enum CompletionItemKind {
   Text = 1,
   Method = 2,

packages/lsp-ws-connection/src/ws-connection.ts

@@ -1,7 +1,7 @@
 import * as events from 'events';
 
 import type * as protocol from 'vscode-languageserver-protocol';
-import { CompletionItemTag, LocationLink } from 'vscode-languageserver-types';
+import type { LocationLink } from 'vscode-languageserver-types';
 import { ConsoleLogger, MessageConnection, listen } from 'vscode-ws-jsonrpc';
 
 import {
@@ -145,66 +145,11 @@ export class LspWsConnection
 
   /**
    * Initialization parameters to be sent to the language server.
-   * Subclasses can overload this when adding more features.
+   * Subclasses should override this when adding more features.
    */
   protected initializeParams(): protocol.InitializeParams {
     return {
-      capabilities: {
-        textDocument: {
-          hover: {
-            dynamicRegistration: true,
-            contentFormat: ['markdown', 'plaintext']
-          },
-          synchronization: {
-            dynamicRegistration: true,
-            willSave: false,
-            didSave: true,
-            willSaveWaitUntil: false
-          },
-          completion: {
-            dynamicRegistration: true,
-            completionItem: {
-              snippetSupport: false,
-              commitCharactersSupport: true,
-              documentationFormat: ['markdown', 'plaintext'],
-              deprecatedSupport: true,
-              preselectSupport: false,
-              tagSupport: {
-                valueSet: [CompletionItemTag.Deprecated]
-              }
-            },
-            contextSupport: false
-          },
-          signatureHelp: {
-            dynamicRegistration: true,
-            signatureInformation: {
-              documentationFormat: ['markdown', 'plaintext']
-            }
-          },
-          declaration: {
-            dynamicRegistration: true,
-            linkSupport: true
-          },
-          definition: {
-            dynamicRegistration: true,
-            linkSupport: true
-          },
-          typeDefinition: {
-            dynamicRegistration: true,
-            linkSupport: true
-          },
-          implementation: {
-            dynamicRegistration: true,
-            linkSupport: true
-          }
-        } as protocol.ClientCapabilities,
-        workspace: {
-          didChangeConfiguration: {
-            dynamicRegistration: true
-          }
-        } as protocol.WorkspaceClientCapabilities
-      } as protocol.ClientCapabilities,
-      initializationOptions: null,
+      capabilities: {} as protocol.ClientCapabilities,
       processId: null,
       rootUri: this.rootUri,
       workspaceFolders: null