Skip to content

Commit 31bf3ec

Browse files
committed
fix connect docs, make calls more explicit
1 parent c676b79 commit 31bf3ec

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/jupyterlab-lsp/src/adapters/jupyterlab/file_editor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class FileEditorAdapter extends JupyterLabWidgetAdapter {
7373

7474
// connect the document, but do not open it as the adapter will handle this
7575
// after registering all features
76-
this.connect_document(this.virtual_editor.virtual_document).catch(
76+
this.connect_document(this.virtual_editor.virtual_document, false).catch(
7777
console.warn
7878
);
7979

packages/jupyterlab-lsp/src/adapters/jupyterlab/jl_adapter.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ export abstract class JupyterLabWidgetAdapter
290290
/**
291291
* Opens a connection for the document. The connection may or may
292292
* not be initialized, yet, and depending on when this is called, the client
293-
* may not be fully connected. In
293+
* may not be fully connected.
294294
*
295295
* @param virtual_document a VirtualDocument
296296
* @param send_open whether to open the document immediately
@@ -324,8 +324,8 @@ export abstract class JupyterLabWidgetAdapter
324324
}
325325

326326
/**
327-
* Handler for opening a document contained in a larger document. The assumption
328-
* is that the editor already exists for this this, and as such the document
327+
* Handler for opening a document contained in a parent document. The assumption
328+
* is that the editor already exists for this, and as such the document
329329
* should be queued for immediate opening.
330330
*
331331
* @param host the VirtualDocument that contains the VirtualDocument in another language

packages/jupyterlab-lsp/src/adapters/jupyterlab/notebook.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ export class NotebookAdapter extends JupyterLabWidgetAdapter {
160160

161161
// connect the document, but do not open it as the adapter will handle this
162162
// after registering all features
163-
this.connect_document(this.virtual_editor.virtual_document).catch(
163+
this.connect_document(this.virtual_editor.virtual_document, false).catch(
164164
console.warn
165165
);
166166
}

0 commit comments

Comments
 (0)