Update CONTRIBUTING.md: add jupyter develop for symlinking,

add missing npm-run-all package that is used for jlpm watch

Author: krassowski

CONTRIBUTING.md

@@ -60,28 +60,29 @@ Once your environment is created and activated, on Linux/OSX you can run:
 bash binder/postBuild
 ```
 
-This performs all of the basic setup steps, and is used for the binder demo.
+This performs all the basic setup steps, and is used for the binder demo.
 
 #### The Hard Way
 
 Install `jupyter-lsp` from source in your virtual environment:
 
 ```bash
-python -m pip install -e . --ignore-installed --no-deps -vv
+python -m pip install -e python_packages/jupter_lsp --ignore-installed --no-deps -vv
 ```
 
 Enable the server extension:
 
 ```bash
-jupyter serverextension enable --sys-prefix --py jupyter_lsp
+jupyter server extension enable --sys-prefix --py jupyter_lsp
 ```
 
 Install `npm` dependencies, build TypeScript packages, and link
 to JupyterLab for development:
 
 ```bash
 jlpm bootstrap
-pip install .
+# if you installed `jupyterlab_lsp` before uninstall it before running the next line
+jupyter labextension develop python_packages/jupyterlab_lsp/ --overwrite
 ```
 
 ### Frontend Development
@@ -100,6 +101,9 @@ jlpm watch   # leave this running...
 jupyter lab --watch  # ...in another terminal
 ```
 
+Now after each change to TypesScript files wait until both watchers finish compilation,
+and then refresh the JupyterLab in your browser.
+
 > Note: the backend schema is not included in `watch`, and is only refreshed by `build`
 
 To check and fix code style:
@@ -226,7 +230,7 @@ python scripts/atest.py --test "Works With Kernel Running"
 
 ##### Run test with a tag
 
-Tags are preferrable to file names and test name matching in many settings, as
+Tags are preferable to file names and test name matching in many settings, as
 they are aggregated nicely between runs.
 
 ```bash

package.json

@@ -16,6 +16,7 @@
     "javascript-typescript-langserver": "^2.11.3",
     "jest-github-actions-reporter": "^1.0.2",
     "lerna": "^3.13.2",
+    "npm-run-all": "^4.1.5",
     "precise-commits": "^1.0.2",
     "prettier": "^2.1.2",
     "sql-language-server": "^0.11.4",

yarn.lock

@@ -1736,7 +1736,7 @@
   version "2.0.0"
 
 "@krassowski/jupyterlab-lsp@file:packages/jupyterlab-lsp":
-  version "2.1.2"
+  version "3.0.0"
   dependencies:
     "@krassowski/code-jumpers" "~1.0.0"
     "@krassowski/completion-theme" "~2.0.0"
@@ -9509,6 +9509,11 @@ memory-fs@^0.5.0:
     errno "^0.1.3"
     readable-stream "^2.0.1"
 
+memorystream@^0.3.1:
+  version "0.3.1"
+  resolved "https://registry.yarnpkg.com/memorystream/-/memorystream-0.3.1.tgz#86d7090b30ce455d63fbae12dda51a47ddcaf9b2"
+  integrity sha1-htcJCzDORV1j+64S3aUaR93K+bI=
+
 meow@^3.3.0:
   version "3.7.0"
   resolved "https://registry.yarnpkg.com/meow/-/meow-3.7.0.tgz#72cb668b425228290abbfa856892587308a801fb"
@@ -10233,6 +10238,21 @@ npm-pick-manifest@^3.0.0:
     npm-package-arg "^6.0.0"
     semver "^5.4.1"
 
+npm-run-all@^4.1.5:
+  version "4.1.5"
+  resolved "https://registry.yarnpkg.com/npm-run-all/-/npm-run-all-4.1.5.tgz#04476202a15ee0e2e214080861bff12a51d98fba"
+  integrity sha512-Oo82gJDAVcaMdi3nuoKFavkIHBRVqQ1qvMb+9LHk/cF4P6B2m8aP04hGf7oL6wZ9BuGwX1onlLhpuoofSyoQDQ==
+  dependencies:
+    ansi-styles "^3.2.1"
+    chalk "^2.4.1"
+    cross-spawn "^6.0.5"
+    memorystream "^0.3.1"
+    minimatch "^3.0.4"
+    pidtree "^0.3.0"
+    read-pkg "^3.0.0"
+    shell-quote "^1.6.1"
+    string.prototype.padend "^3.0.0"
+
 npm-run-path@^2.0.0:
   version "2.0.2"
   resolved "https://registry.yarnpkg.com/npm-run-path/-/npm-run-path-2.0.2.tgz#35a9232dfa35d7067b4cb2ddf2357b1871536c5f"
@@ -10996,6 +11016,11 @@ picomatch@^2.0.4, picomatch@^2.0.5, picomatch@^2.2.1:
   resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-2.2.2.tgz#21f333e9b6b8eaff02468f5146ea406d345f4dad"
   integrity sha512-q0M/9eZHzmr0AulXyPwNfZjtwZ/RBZlbN3K3CErVrk50T2ASYI7Bye0EvekFY3IP1Nt2DHu0re+V2ZHIpMkuWg==
 
+pidtree@^0.3.0:
+  version "0.3.1"
+  resolved "https://registry.yarnpkg.com/pidtree/-/pidtree-0.3.1.tgz#ef09ac2cc0533df1f3250ccf2c4d366b0d12114a"
+  integrity sha512-qQbW94hLHEqCg7nhby4yRC7G2+jYHY4Rguc2bjw7Uug4GIJuu1tvf2uHaZv5Q8zdt+WKJ6qK1FOI6amaWUo5FA==
+
 pify@^2.0.0, pify@^2.3.0:
   version "2.3.0"
   resolved "https://registry.yarnpkg.com/pify/-/pify-2.3.0.tgz#ed141a6ac043a849ea588498e7dca8b15330e90c"
@@ -12894,6 +12919,11 @@ shebang-regex@^3.0.0:
   resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-3.0.0.tgz#ae16f1644d873ecad843b0307b143362d4c42172"
   integrity sha512-7++dFhtcx3353uBaq8DDR4NuxBetBzC7ZQOhmTQInHEd6bSrXdiEyzCvG07Z44UYdLShWUyXt5M/yhz8ekcb1A==
 
+shell-quote@^1.6.1:
+  version "1.7.2"
+  resolved "https://registry.yarnpkg.com/shell-quote/-/shell-quote-1.7.2.tgz#67a7d02c76c9da24f99d20808fcaded0e0e04be2"
+  integrity sha512-mRz/m/JVscCrkMyPqHc/bczi3OQHkLTqXHEFu0zDhK/qfv3UcOA4SVmRCLmos4bhjr9ekVQubj/R7waKapmiQg==
+
 shelljs@^0.8.2:
   version "0.8.4"
   resolved "https://registry.yarnpkg.com/shelljs/-/shelljs-0.8.4.tgz#de7684feeb767f8716b326078a8a00875890e3c2"
@@ -13452,6 +13482,15 @@ string.prototype.matchall@^4.0.2:
     regexp.prototype.flags "^1.3.0"
     side-channel "^1.0.2"
 
+string.prototype.padend@^3.0.0:
+  version "3.1.1"
+  resolved "https://registry.yarnpkg.com/string.prototype.padend/-/string.prototype.padend-3.1.1.tgz#824c84265dbac46cade2b957b38b6a5d8d1683c5"
+  integrity sha512-eCzTASPnoCr5Ht+Vn1YXgm8SB015hHKgEIMu9Nr9bQmLhRBxKRfmzSj/IQsxDFc8JInJDDFA0qXwK+xxI7wDkg==
+  dependencies:
+    call-bind "^1.0.0"
+    define-properties "^1.1.3"
+    es-abstract "^1.18.0-next.1"
+
 string.prototype.trimend@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/string.prototype.trimend/-/string.prototype.trimend-1.0.2.tgz#6ddd9a8796bc714b489a3ae22246a208f37bfa46"