Skip to content

Commit 58d9561

Browse files
bollwyvlbollwyvl
committed
linting
1 parent 16876bd commit 58d9561

File tree

6 files changed

+43
-26
lines changed

6 files changed

+43
-26
lines changed

‎atest/05_Features/Completion.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ Activate Completer Suggestion
400400
Capture Page Screenshot ${i}-completions.png
401401
${matching_active_elements} = Get Element Count ${active_suggestion}
402402
LOG ${matching_active_elements}
403-
IF ${matching_active_elements} == 1 BREAK
403+
IF ${matching_active_elements} == 1 BREAK
404404
Press Keys None DOWN
405405
Sleep 0.1s
406406
END

‎docs/Language Servers.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@
360360
"| Scala | [scalameta/metals] | (2) |\n",
361361
"\n",
362362
"[jupyrdf/graph-lsp]: https://github.com/jupyrdf/graph-lsp\n",
363-
"[CybercentreCanada/jupyterlab-sql-editor]:\n",
363+
"[cybercentrecanada/jupyterlab-sql-editor]:\n",
364364
" https://github.com/CybercentreCanada/jupyterlab-sql-editor\n",
365365
"[jupyter-lsp/json-lsp]: https://github.com/jupyter-lsp/json-lsp\n",
366366
"[jupyter-lsp/yaml-lsp]: https://github.com/jupyter-lsp/yaml-lsp\n",

‎packages/jupyterlab-lsp/src/connection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ export class LSPConnection extends LspWsConnection {
452452
method,
453453
message: params
454454
});
455-
this.connection.sendNotification(method, params);
455+
void this.connection.sendNotification(method, params);
456456
});
457457
}
458458

@@ -618,7 +618,7 @@ export class LSPConnection extends LspWsConnection {
618618
} as lsp.VersionedTextDocumentIdentifier,
619619
contentChanges: changeEvents
620620
};
621-
this.connection.sendNotification(
621+
void this.connection.sendNotification(
622622
'textDocument/didChange',
623623
textDocumentChange
624624
);

‎packages/lsp-ws-connection/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
"lsp",
2525
"languageserver"
2626
],
27-
"homepage": "https://github.com/krassowski/jupyterlab-lsp/tree/master/packages/lsp-ws-connection",
28-
"repository": "github:krassowski/jupyterlab-lsp",
27+
"homepage": "https://github.com/jupyter-lsp/jupyterlab-lsp/tree/master/packages/lsp-ws-connection",
28+
"repository": "github:jupyter-lsp/jupyterlab-lsp",
2929
"dependencies": {
3030
"vscode-jsonrpc": "^6.0.0",
3131
"vscode-languageserver-protocol": "^3.16.0",
3232
"vscode-languageserver-types": "^3.16.0",
33-
"vscode-ws-jsonrpc": "0.2.0"
33+
"vscode-ws-jsonrpc": "~1.0.2"
3434
},
3535
"devDependencies": {
3636
"@types/chai": "^4.1.7",

‎packages/lsp-ws-connection/src/ws-connection.ts

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export class LspWsConnection
188188
version: documentInfo.version
189189
} as protocol.TextDocumentItem
190190
};
191-
this.connection.sendNotification(
191+
void this.connection.sendNotification(
192192
'textDocument/didOpen',
193193
textDocumentMessage
194194
);
@@ -211,7 +211,7 @@ export class LspWsConnection
211211
} as protocol.VersionedTextDocumentIdentifier,
212212
contentChanges: [{ text: documentInfo.text }]
213213
};
214-
this.connection.sendNotification(
214+
void this.connection.sendNotification(
215215
'textDocument/didChange',
216216
textDocumentChange
217217
);
@@ -230,7 +230,7 @@ export class LspWsConnection
230230
} as protocol.VersionedTextDocumentIdentifier,
231231
text: documentInfo.text
232232
};
233-
this.connection.sendNotification(
233+
void this.connection.sendNotification(
234234
'textDocument/didSave',
235235
textDocumentChange
236236
);
@@ -243,12 +243,15 @@ export class LspWsConnection
243243
return;
244244
}
245245

246-
this.connection.sendNotification(
246+
void this.connection.sendNotification(
247247
'workspace/didChangeConfiguration',
248248
settings
249249
);
250250
}
251251

252+
/**
253+
* @deprecated
254+
*/
252255
public async getHoverTooltip(
253256
location: IPosition,
254257
documentInfo: IDocumentInfo,
@@ -280,6 +283,9 @@ export class LspWsConnection
280283
return hover;
281284
}
282285

286+
/**
287+
* @deprecated
288+
*/
283289
public async getCompletion(
284290
location: IPosition,
285291
token: ITokenInfo,
@@ -380,6 +386,7 @@ export class LspWsConnection
380386

381387
/**
382388
* Request the locations of all matching document symbols
389+
* @deprecated
383390
*/
384391
public async getDocumentHighlights(
385392
location: IPosition,
@@ -412,6 +419,7 @@ export class LspWsConnection
412419
/**
413420
* Request a link to the definition of the current symbol. The results will not be displayed
414421
* unless they are within the same file URI
422+
* @deprecated
415423
*/
416424
public async getDefinition(
417425
location: IPosition,
@@ -447,6 +455,7 @@ export class LspWsConnection
447455
/**
448456
* Request a link to the type definition of the current symbol. The results will not be displayed
449457
* unless they are within the same file URI
458+
* @deprecated
450459
*/
451460
public async getTypeDefinition(
452461
location: IPosition,
@@ -482,6 +491,7 @@ export class LspWsConnection
482491
/**
483492
* Request a link to the implementation of the current symbol. The results will not be displayed
484493
* unless they are within the same file URI
494+
* @deprecated
485495
*/
486496
public getImplementation(location: IPosition, documentInfo: IDocumentInfo) {
487497
if (!this.isReady || !this.isImplementationSupported()) {
@@ -509,6 +519,7 @@ export class LspWsConnection
509519
/**
510520
* Request a link to all references to the current symbol. The results will not be displayed
511521
* unless they are within the same file URI
522+
* @deprecated
512523
*/
513524
public async getReferences(
514525
location: IPosition,
@@ -546,13 +557,15 @@ export class LspWsConnection
546557

547558
/**
548559
* The characters that trigger completion automatically.
560+
* @deprecated
549561
*/
550562
public getLanguageCompletionCharacters(): string[] {
551563
return this.serverCapabilities?.completionProvider?.triggerCharacters || [];
552564
}
553565

554566
/**
555567
* The characters that trigger signature help automatically.
568+
* @deprecated
556569
*/
557570
public getLanguageSignatureCharacters(): string[] {
558571
return (
@@ -562,27 +575,31 @@ export class LspWsConnection
562575

563576
/**
564577
* Does the server support go to definition?
578+
* @deprecated
565579
*/
566580
public isDefinitionSupported() {
567581
return !!this.serverCapabilities?.definitionProvider;
568582
}
569583

570584
/**
571585
* Does the server support go to type definition?
586+
* @deprecated
572587
*/
573588
public isTypeDefinitionSupported() {
574589
return !!this.serverCapabilities?.typeDefinitionProvider;
575590
}
576591

577592
/**
578593
* Does the server support go to implementation?
594+
* @deprecated
579595
*/
580596
public isImplementationSupported() {
581597
return !!this.serverCapabilities?.implementationProvider;
582598
}
583599

584600
/**
585601
* Does the server support find all references?
602+
* @deprecated
586603
*/
587604
public isReferencesSupported() {
588605
return !!this.serverCapabilities?.referencesProvider;
@@ -591,8 +608,8 @@ export class LspWsConnection
591608
protected onServerInitialized(params: protocol.InitializeResult) {
592609
this.isInitialized = true;
593610
this.serverCapabilities = params.capabilities;
594-
this.connection.sendNotification('initialized', {});
595-
this.connection.sendNotification('workspace/didChangeConfiguration', {
611+
void this.connection.sendNotification('initialized', {});
612+
void this.connection.sendNotification('workspace/didChangeConfiguration', {
596613
settings: {}
597614
});
598615
this.emit('serverInitialized', this.serverCapabilities);

‎yarn.lock

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9230,7 +9230,7 @@ [email protected]:
92309230
vscode-jsonrpc "^6.0.0"
92319231
vscode-languageserver-protocol "^3.16.0"
92329232
vscode-languageserver-types "^3.16.0"
9233-
vscode-ws-jsonrpc "0.2.0"
9233+
vscode-ws-jsonrpc "~1.0.2"
92349234

92359235
ltgt@^2.1.2:
92369236
version "2.2.1"
@@ -9542,12 +9542,7 @@ [email protected]:
95429542
is-plain-obj "^1.1.0"
95439543
kind-of "^6.0.3"
95449544

9545-
minimist@^1.1.1, minimist@^1.2.5, minimist@^1.2.6, minimist@~1.2.0:
9546-
version "1.2.6"
9547-
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
9548-
integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==
9549-
9550-
minimist@^1.2.0:
9545+
minimist@^1.1.1, minimist@^1.2.0, minimist@^1.2.5, minimist@^1.2.6, minimist@~1.2.0:
95519546
version "1.2.7"
95529547
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.7.tgz#daa1c4d91f507390437c6a8bc01078e7000c4d18"
95539548
integrity sha512-bzfL1YUZsP41gmu/qjrEk0Q6i2ix/cVeAhbCbqH9u3zYutS1cLg00qhrD0M2MVdCcx4Sc0UpP2eBWo9rotpq6g==
@@ -14079,11 +14074,16 @@ vscode-jsonrpc@^4.0.0:
1407914074
resolved "https://registry.yarnpkg.com/vscode-jsonrpc/-/vscode-jsonrpc-4.0.0.tgz#a7bf74ef3254d0a0c272fab15c82128e378b3be9"
1408014075
integrity sha512-perEnXQdQOJMTDFNv+UF3h1Y0z4iSiaN9jIlb0OqIYgosPCZGYh/MCUlkFtV2668PL69lRDO32hmvL2yiidUYg==
1408114076

14082-
vscode-jsonrpc@^5.0.0, vscode-jsonrpc@^5.0.1:
14077+
vscode-jsonrpc@^5.0.1:
1408314078
version "5.0.1"
1408414079
resolved "https://registry.yarnpkg.com/vscode-jsonrpc/-/vscode-jsonrpc-5.0.1.tgz#9bab9c330d89f43fc8c1e8702b5c36e058a01794"
1408514080
integrity sha512-JvONPptw3GAQGXlVV2utDcHx0BiY34FupW/kI6mZ5x06ER5DdPG/tXWMVHjTNULF5uKPOUUD0SaXg5QaubJL0A==
1408614081

14082+
vscode-jsonrpc@^8.0.2:
14083+
version "8.0.2"
14084+
resolved "https://registry.npmjs.org/vscode-jsonrpc/-/vscode-jsonrpc-8.0.2.tgz#f239ed2cd6004021b6550af9fd9d3e47eee3cac9"
14085+
integrity sha512-RY7HwI/ydoC1Wwg4gJ3y6LpU9FJRZAUnTYMXthqhFXXu77ErDd/xkREpGuk4MyYkk4a+XDWAMqe0S3KkelYQEQ==
14086+
1408714087
vscode-languageclient@^6.1.3:
1408814088
version "6.1.4"
1408914089
resolved "https://registry.yarnpkg.com/vscode-languageclient/-/vscode-languageclient-6.1.4.tgz#54aa8b1559ae2e0499cb6ab746cc2662fb6ecc0f"
@@ -14275,12 +14275,12 @@ vscode-uri@^3.0.2:
1427514275
resolved "https://registry.yarnpkg.com/vscode-uri/-/vscode-uri-3.0.3.tgz#a95c1ce2e6f41b7549f86279d19f47951e4f4d84"
1427614276
integrity sha512-EcswR2S8bpR7fD0YPeS7r2xXExrScVMxg4MedACaWHEtx9ftCF/qHG1xGkolzTPcEmjTavCQgbVzHUIdTMzFGA==
1427714277

14278-
[email protected].0:
14279-
version "0.2.0"
14280-
resolved "https://registry.npmjs.org/vscode-ws-jsonrpc/-/vscode-ws-jsonrpc-0.2.0.tgz#5e9c26e10da54a1a235da7d59e74508bbcb8edd9"
14281-
integrity sha512-NE9HNRgPjCaPyTJvIudcpyIWPImxwRDtuTX16yks7SAiZgSXigxAiZOvSvVBGmD1G/OMfrFo6BblOtjVR9DdVA==
14278+
vscode-ws-jsonrpc@~1.0.2:
14279+
version "1.0.2"
14280+
resolved "https://registry.yarnpkg.com/vscode-ws-jsonrpc/-/vscode-ws-jsonrpc-1.0.2.tgz#ead2efd66293f331ccc220222ae1aeca4bb5b2c1"
14281+
integrity sha512-09OpRC0RcqZs4DleJRgs+R+7gQkwb4tgvsL43lzVZwW4N5NO3H/9sLNeKPBt83k7WyA8qBZjrzM6X7tKFpFrjQ==
1428214282
dependencies:
14283-
vscode-jsonrpc "^5.0.0"
14283+
vscode-jsonrpc "^8.0.2"
1428414284

1428514285
w3c-hr-time@^1.0.2:
1428614286
version "1.0.2"

0 commit comments

Comments
 (0)