Skip to content

Commit 6284337

Browse files
committed
Fix setting name used in test and increase timeout
1 parent c89e8fc commit 6284337

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

atest/05_Features/Completion.robot

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ${DOCUMENTATION_PANEL} css:.jp-Completer-docpanel
1111
${KERNEL_BUSY_INDICATOR} css:.jp-NotebookPanel-toolbar div[title="Kernel Busy"]
1212

1313
*** Test Cases ***
14-
Works With Kernel Is Idle
14+
Works When Kernel Is Idle
1515
[Documentation] The suggestions from kernel and LSP should get integrated.
1616
Enter Cell Editor 1 line=2
1717
Capture Page Screenshot 01-entered-cell.png
@@ -29,12 +29,12 @@ Works With Kernel Is Idle
2929
Should Contain ${content} TabError
3030

3131
Uses LSP Completions When Kernel Resoponse Times Out
32-
Configure JupyterLab Plugin {"kernelResponseTimeout": 1, "waitForKernelIfBusy": true} plugin id=${COMPLETION PLUGIN ID}
32+
Configure JupyterLab Plugin {"kernelResponseTimeout": 1, "waitForBusyKernel": true} plugin id=${COMPLETION PLUGIN ID}
3333
Should Complete While Kernel Is Busy
3434

3535
Uses LSP Completions When Kernel Is Busy
3636
[Documentation] When kernel is not available the best thing is to show some suggestions (LSP) rather than none.
37-
Configure JupyterLab Plugin {"kernelResponseTimeout": -1, "waitForKernelIfBusy": false} plugin id=${COMPLETION PLUGIN ID}
37+
Configure JupyterLab Plugin {"kernelResponseTimeout": -1, "waitForBusyKernel": false} plugin id=${COMPLETION PLUGIN ID}
3838
Should Complete While Kernel Is Busy
3939

4040
Works When Kernel Is Shut Down
@@ -309,18 +309,18 @@ Count Completer Hints
309309
[Return] ${count}
310310

311311
Should Complete While Kernel Is Busy
312-
# Run the cell with sleep(10)
312+
# Run the cell with sleep(20)
313313
Enter Cell Editor 17
314314
# for some reason the lab command selects another cell along the way...
315315
# Lab Command Run Selected Cells And Don't Advance
316316
Press Keys None CTRL+ENTER
317317
# Confirm that the kernel is busy
318-
Wait Until Page Contains Element ${KERNEL_BUSY_INDICATOR} timeout=3s
318+
Wait Until Page Contains Element ${KERNEL_BUSY_INDICATOR} timeout=5s
319319
# Enter a cell with "t"
320320
Enter Cell Editor 18
321321
# Check if completion worked
322322
Enter Cell Editor 1 line=2
323-
Trigger Completer timeout=3s
324-
Completer Should Suggest test timeout=3s
323+
Trigger Completer timeout=10s
324+
Completer Should Suggest test
325325
# Confirm that the kernel indicator was busy all along
326326
Page Should Contain Element ${KERNEL_BUSY_INDICATOR}

atest/examples/Completion.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
"outputs": [],
140140
"source": [
141141
"from time import sleep\n",
142-
"sleep(10)"
142+
"sleep(20)"
143143
]
144144
},
145145
{

0 commit comments

Comments
 (0)