tweak some tests to avoid false webdriver 'rect' errors, wait for editor initialization

Author: bollwyvl

atest/01_Editor.robot

@@ -28,6 +28,11 @@ JSX
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable')][contains(text(), 'hello')])[last()]
     Editor Shows Features for Language    JSX    example.jsx    Diagnostics=Expression expected    Jump to Definition=${def}    Rename=${def}
 
+LaTeX
+    [Tags]    language:latex
+    ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-atom')][contains(text(), 'foo')])[last()]
+    Editor Shows Features for Language    LaTeX    example.tex    Jump to Definition=${def}    Rename=${def}
+
 Less
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable-2')][contains(text(), '@width')])[last()]
     Editor Shows Features for Language    Less    example.less    Diagnostics=Do not use empty rulesets    Jump to Definition=${def}
@@ -47,11 +52,6 @@ SCSS
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable-2')][contains(text(), 'primary-color')])[last()]
     Editor Shows Features for Language    SCSS    example.scss    Diagnostics=Do not use empty rulesets    Jump to Definition=${def}
 
-LaTeX
-    [Tags]    language:latex
-    ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-atom')][contains(text(), 'foo')])[last()]
-    Editor Shows Features for Language    LaTeX    example.tex    Jump to Definition=${def}    Rename=${def}
-
 TSX
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-tag')][contains(text(), 'HelloWorld')])[last()]
     Editor Shows Features for Language    TSX    example.tsx    Diagnostics=Cannot find module 'react'    Jump to Definition=${def}    Rename=${def}
@@ -67,6 +67,7 @@ YAML
 Editor Shows Features for Language
     [Arguments]    ${Language}    ${file}    &{features}
     Prepare File for Editing    ${Language}    editor    ${file}
+    Wait Until Fully Initialized
     FOR    ${f}    IN    @{features}
         Run Keyword If    "${f}" == "Diagnostics"    Editor Should Show Diagnostics    ${features["${f}"]}
         ...    ELSE IF    "${f}" == "Jump to Definition"    Editor Should Jump To Definition    ${features["${f}"]}

atest/03_Notebook.robot

@@ -5,26 +5,27 @@ Resource          Keywords.robot
 
 *** Test Cases ***
 Python
-    Setup Notebook    Python    Python.ipynb
-    Capture Page Screenshot    01-python.png
+    [Setup]    Setup Notebook    Python    Python.ipynb
     ${diagnostic} =    Set Variable    W291 trailing whitespace (pycodestyle)
     Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=35s
-    Capture Page Screenshot    02-python.png
-    Clean Up After Working With File    Python.ipynb
+    Capture Page Screenshot    01-python.png
+    [Teardown]    Clean Up After Working With File    Python.ipynb
 
 Foreign Extractors
     ${file} =    Set Variable    Foreign extractors.ipynb
-    Configure JupyterLab Plugin    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}}}
+    Configure JupyterLab Plugin
+    ...    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}}}
+    Capture Page Screenshot    10-configured.png
+    Reset Application State
     Setup Notebook    Python    ${file}
-    # if mypy and pyflakes will fight over `(N|n)ame 'valid'`, just hope for the best
     @{diagnostics} =    Create List
     ...    Failed to parse expression    # bash
-    ...    ame 'valid'    # python
+    ...    ame 'valid'    # python, mypy and pyflakes will fight over `(N|n)ame 'valid'`, just hope for the best
     ...    Trailing whitespace is superfluous.    # r
     ...    `frob` is misspelt    # markdown
     ...    Command terminated with space    # latex
     FOR    ${diagnostic}    IN    @{diagnostics}
         Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title*\="${diagnostic}"]    timeout=35s
-        Capture Page Screenshot    0x-${diagnostic}.png
     END
+    Capture Page Screenshot    11-extracted.png
     [Teardown]    Clean Up After Working with File and Settings    ${file}

atest/07_Configuration.robot

@@ -33,7 +33,7 @@ LaTeX
     Settings Should Change Editor Diagnostics    LaTeX    example.tex    texlab
     ...    {"latex.lint.onChange": true}
     ...    ${EMPTY}
-    ...    Command terminated with space. (chktex)
+    ...    Delete this space to maintain correct pagereferences.
     ...    Save File
     ...    ${needs reload}
 

atest/examples/example.tex

@@ -3,5 +3,4 @@
 \begin{document}
     \label{foo}
     \ref{foo}
-    \foo This is an error.
 \end{document}