Merge pull request #928 from krassowski/fix-mark-highlight-in-dark-mode

krassowski · web-flow · commit 661b7435dd81 · 2023-04-17T09:12:20.000+01:00
Fix contrast of mark highlights in dark mode
diff --git a/packages/jupyterlab-lsp/style/signature.css b/packages/jupyterlab-lsp/style/signature.css
@@ -1,3 +1,13 @@
-.lsp-signature-help pre code {
+.lsp-signature-help code {
   font-size: var(--jp-code-font-size);
 }
+
+.lsp-signature-help code > mark {
+  color: var(--jp-lsp-signature-mark-color);
+  background: var(--jp-lsp-signature-mark-background);
+}
+
+.lsp-signature-help code > mark > span {
+  /* override syntax highlight colour to ensure contrast */
+  color: var(--jp-lsp-signature-mark-color) !important;
+}
diff --git a/packages/jupyterlab-lsp/style/variables/base.css b/packages/jupyterlab-lsp/style/variables/base.css
@@ -18,4 +18,7 @@
   /* hover */
   --jp-editor-mirror-lsp-hover-decoration-style: dotted;
   --jp-editor-mirror-lsp-hover-decoration-color: var(--jp-brand-color1);
+  /* signature */
+  --jp-lsp-signature-mark-color: black;
+  --jp-lsp-signature-mark-background: yellow;
 }
diff --git a/packages/jupyterlab-lsp/style/variables/jupyterlab-dark.css b/packages/jupyterlab-lsp/style/variables/jupyterlab-dark.css
@@ -1,3 +1,8 @@
 body[data-jp-theme-light='false'] .cm-s-jupyter {
   --jp-editor-mirror-lsp-highlight-background-color: rgba(151, 173, 255, 0.3);
 }
+
+body[data-jp-theme-light='false'] {
+  --jp-lsp-signature-mark-color: white;
+  --jp-lsp-signature-mark-background: #607e01;
+}

Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,7 @@`
`18`	`18`	`/* hover */`
`19`	`19`	`--jp-editor-mirror-lsp-hover-decoration-style: dotted;`
`20`	`20`	`--jp-editor-mirror-lsp-hover-decoration-color: var(--jp-brand-color1);`
	`21`	`+ /* signature */`
	`22`	`+ --jp-lsp-signature-mark-color: black;`
	`23`	`+ --jp-lsp-signature-mark-background: yellow;`
`21`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,8 @@`
`1`	`1`	`body[data-jp-theme-light='false'] .cm-s-jupyter {`
`2`	`2`	`--jp-editor-mirror-lsp-highlight-background-color: rgba(151, 173, 255, 0.3);`
`3`	`3`	`}`
	`4`	`+`
	`5`	`+body[data-jp-theme-light='false'] {`
	`6`	`+ --jp-lsp-signature-mark-color: white;`
	`7`	`+ --jp-lsp-signature-mark-background: #607e01;`
	`8`	`+}`