Skip to content

Commit 6dcde0a

Browse files
committed
Working implementation for pyls and r-language-server, YAML still not behaving
1 parent fdb1d35 commit 6dcde0a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

packages/jupyterlab-lsp/src/connection_manager.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,13 +152,19 @@ export class DocumentConnectionManager {
152152
return connection;
153153
}
154154

155+
/**
156+
* Currently only supports the settings that the language servers
157+
* accept using onDidChangeConfiguration messages, under the
158+
* "serverSettings" keyword in the setting registry. New keywords can
159+
* be added and extra functionality implemented here when needed.
160+
*/
155161
public updateServerConfigurations(
156162
// TODO: define types for server configurations
157163
lsSettings: any
158164
) {
159165
for (let language_server_id in lsSettings) {
160166
const parsedSettings = vscodeStyleSettingsParser(
161-
lsSettings[language_server_id]
167+
lsSettings[language_server_id].serverSettings
162168
);
163169

164170
const serverSettings: ILanguageServerConfiguration = {

0 commit comments

Comments
 (0)