Skip to content

Commit 7130b8a

Browse files
committed
Increase timeouts even more to prevent Windows flake,
fix a typo in Signature.ipynb notebook
1 parent d76c8e5 commit 7130b8a

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

atest/05_Features/Completion.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Triggers Completer On Dot
6666
Wait Until Fully Initialized
6767
Press Keys None .
6868
Wait Until Keyword Succeeds 10x 0.5s Cell Editor Should Equal 2 list.
69-
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=25s
69+
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=35s
7070
Completer Should Suggest append
7171
[Teardown] Clean Up After Working With File Completion.ipynb
7272

@@ -91,4 +91,4 @@ Completer Should Not Suggest
9191

9292
Trigger Completer
9393
Press Keys None TAB
94-
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=25s
94+
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=35s

atest/Keywords.robot

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ Ensure All Kernels Are Shut Down
7878
Enter Command Name Shut Down All Kernels
7979
${els} = Get WebElements ${CMD PALETTE ITEM ACTIVE}
8080
Run Keyword If ${els.__len__()} Click Element ${CMD PALETTE ITEM ACTIVE}
81-
Run Keyword If ${els.__len__()} Click Element css:.jp-mod-accept.jp-mod-warn
81+
${accept} = Set Variable css:.jp-mod-accept.jp-mod-warn
82+
Run Keyword If ${els.__len__()} Wait Until Page Contains Element ${accept}
83+
Run Keyword If ${els.__len__()} Click Element ${accept}
8284

8385
Open Command Palette
8486
Press Keys id:main ${ACCEL}+SHIFT+c
@@ -196,4 +198,4 @@ Enter Cell Editor
196198
Wait Until Page Contains Element css:.jp-CodeCell:nth-child(${cell_nr}) .CodeMirror-focused
197199

198200
Wait Until Fully Initialized
199-
Wait Until Element Contains ${STATUSBAR} Fully initialized timeout=30s
201+
Wait Until Element Contains ${STATUSBAR} Fully initialized timeout=35s

atest/examples/Signature.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"source": [
1414
"def abc(x=1):\n",
1515
" \"\"\"Important docstring of abc()\"\"\"\n",
16-
" pas\n",
16+
" pass\n",
1717
"\n",
1818
"\n",
1919
"abc"

0 commit comments

Comments
 (0)