Merge pull request #732 from jupyter-lsp/squash-warnings

Squash warnings and errors in web console

Author: krassowski

packages/jupyterlab-lsp/src/adapters/adapter.ts

@@ -722,7 +722,11 @@ export abstract class WidgetAdapter<T extends IDocumentWidget> {
 
   abstract context_from_active_document(): ICommandContext | null;
 
-  get_context(root_position: IRootPosition): ICommandContext {
+  get_context(root_position: IRootPosition): ICommandContext | null {
+    // ignore premature calls and calls after disposal
+    if (!this.virtual_editor) {
+      return null;
+    }
     let document = this.virtual_editor.document_at_root_position(root_position);
     let virtual_position =
       this.virtual_editor.root_position_to_virtual_position(root_position);
@@ -738,7 +742,7 @@ export abstract class WidgetAdapter<T extends IDocumentWidget> {
     };
   }
 
-  get_context_from_context_menu(): ICommandContext {
+  get_context_from_context_menu(): ICommandContext | null {
     let root_position = this.get_position_from_context_menu();
     return this.get_context(root_position);
   }

packages/jupyterlab-lsp/src/features/diagnostics/diagnostics.ts

@@ -620,7 +620,8 @@ export class DiagnosticsCM extends CodeMirrorIntegration {
     connection: LSPConnection,
     response: lsProtocol.PublishDiagnosticsParams
   ) => {
-    if (!uris_equal(response.uri, this.virtual_document.document_info.uri)) {
+    // use optional chaining operator because the diagnostics message may come late (after the document was disposed)
+    if (!uris_equal(response.uri, this.virtual_document?.document_info?.uri)) {
       return;
     }
 

packages/jupyterlab-lsp/src/virtual/codemirror_editor.ts

@@ -537,7 +537,9 @@ export class CodeMirrorVirtualEditor
   forEveryBlockEditor(
     callback: (cm_editor: CodeMirror.Editor) => any,
     monitor_for_new_blocks = true,
-    on_editor_removed_callback: (cm_editor: CodeMirror.Editor) => any = null
+    on_editor_removed_callback: (
+      cm_editor: CodeMirror.Editor
+    ) => any | null = null
   ) {
     const editors_with_handlers = new Set<CodeMirror.Editor>();
 
@@ -568,6 +570,9 @@ export class CodeMirrorVirtualEditor
         adapter: WidgetAdapter<IDocumentWidget>,
         data: IEditorChangedData
       ) => {
+        if (on_editor_removed_callback == null) {
+          return;
+        }
         let { editor } = data;
         if (editor == null) {
           return;