Skip to content

Commit 7a70799

Browse files
committed
Refactor jump-to functionality, remove unused code
1 parent 11ace76 commit 7a70799

File tree

25 files changed

+214
-2586
lines changed

25 files changed

+214
-2586
lines changed

packages/jupyterlab-go-to-definition/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@krassowski/jupyterlab_go_to_definition",
3-
"version": "1.0.0",
3+
"version": "1.1.0",
44
"description": "Jump to definition of a variable or function in JupyterLab",
55
"keywords": [
66
"jupyter",

packages/jupyterlab-go-to-definition/src/editors/codemirror/extension.spec.ts

Lines changed: 0 additions & 75 deletions
This file was deleted.

packages/jupyterlab-go-to-definition/src/editors/codemirror/extension.ts

Lines changed: 0 additions & 216 deletions
This file was deleted.

packages/jupyterlab-go-to-definition/src/editors/codemirror/index.ts

Lines changed: 0 additions & 2 deletions
This file was deleted.

packages/jupyterlab-go-to-definition/src/editors/codemirror/tokens.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/jupyterlab-go-to-definition/src/editors/editor.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/jupyterlab-go-to-definition/src/history.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { IJumpPosition } from './jump';
1+
import { IGlobalPosition } from './jump';
22
import { IModelDB, IObservableUndoableList } from '@jupyterlab/observables';
33
import { JSONValue } from '@lumino/coreutils';
44

@@ -24,12 +24,12 @@ export class JumpHistory {
2424
}
2525
}
2626

27-
store(position: IJumpPosition) {
27+
store(position: IGlobalPosition) {
2828
this.ensure_history_is_ready();
2929
this.jump_history.push(JSON.stringify(position));
3030
}
3131

32-
recollect(): IJumpPosition {
32+
recollect(): IGlobalPosition {
3333
this.ensure_history_is_ready();
3434
if (this.jump_history.length === 0) {
3535
return;
@@ -38,6 +38,6 @@ export class JumpHistory {
3838
// being lazy here - undo addition instead of removal ;)
3939
this.jump_history.undo();
4040

41-
return JSON.parse(last_position as string) as IJumpPosition;
41+
return JSON.parse(last_position as string) as IGlobalPosition;
4242
}
4343
}

0 commit comments

Comments
 (0)