Skip to content

Commit 7f20250

Browse files
authored
Merge pull request #1061 from krassowski/prepare-relase-5.1.0
Prepare jupyterlab-lsp 5.1.0 and jupyter-lsp 2.2.3 releases
2 parents 93adefd + 4a1bc75 commit 7f20250

File tree

6 files changed

+40
-9
lines changed

6 files changed

+40
-9
lines changed

CHANGELOG.md

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,30 @@
22

33
### `@jupyter-lsp/jupyterlab-lsp 5.1.0`
44

5-
> TBD
5+
Requires JupyterLab `>=4.1.0,<5.0.0a0`
66

7-
### `jupyter-lsp 2.2.2`
7+
- new features:
8+
- populate table of contents with code symbols outline (experimental, file editor only)
9+
- bug fixes:
10+
- fix settings reconciliation for nested properties (#1051)
11+
- fix a regression introduced in v5.0.2 which meant that overrides for native kernel and context completion providers were never active (#1057)
12+
- reduces some warnings in places known to have false positives to debug statements (#1057)
13+
- highlights no longer get instantly removed when navigating to a beginning of cell from another cell (#1057)
14+
- with the use of the new `extensionFactory` API (#1057):
15+
- LSP features work more reliably as the correct virtual document and editor is known rather than found from heuristics
16+
- LSP CodeMirror extensions are not added to editors which do not have an LSP-enabled editor reducing spurious warnings and improving performance
17+
- LSP CodeMirror extensions are only added once the LSP server was connected
18+
- maintenance:
19+
- use new `extensionFactory` API allowing to remove workarounds that were needed to make the extension work in JupyterLab 4.0 (#1057)
20+
- remove no-longer needed patches for `VirtualDocument` as these were merged upstream and released in JupyterLab 4.1 (#1057)
21+
- update coverage, robot version and reporting approaches (#1052)
22+
- build against JupyterLab 4.1, fix tests (#1057)
23+
- bump ip from 2.0.0 to 2.0.1 (#1055)
824

9-
> TBD
25+
### `jupyter-lsp 2.2.3`
1026

11-
Requires JupyterLab `>=4.1.0,<5.0.0a0`
27+
- maintenance:
28+
- updates pyright config schema to v1.1.350
1229

1330
### `@jupyter-lsp/jupyterlab-lsp 5.0.3`
1431

packages/jupyterlab-lsp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@jupyter-lsp/jupyterlab-lsp",
3-
"version": "5.0.3",
3+
"version": "5.1.0",
44
"description": "Language Server Protocol integration for JupyterLab",
55
"keywords": [
66
"jupyter",

packages/jupyterlab-lsp/src/adapters/fileeditor.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import {
1212
import {
1313
ILSPCodeExtractorsManager,
1414
ILSPFeatureManager,
15-
ILSPDocumentConnectionManager
15+
ILSPDocumentConnectionManager,
16+
IEditorChangedData
1617
} from '@jupyterlab/lsp';
1718

1819
import { ILSPCodeOverridesManager } from '../overrides/tokens';
@@ -28,6 +29,18 @@ export class FileEditorAdapter extends UpstreamFileEditorAdapter {
2829
protected options: IAdapterOptions
2930
) {
3031
super(editorWidget, options);
32+
// Workaround to ensure `_editorAdded` is not called twice once upstream
33+
// adopts patch https://github.com/jupyterlab/jupyterlab/pull/15873
34+
let emitted = false;
35+
const emit = this._editorAdded.emit;
36+
this._editorAdded.emit = (args: IEditorChangedData) => {
37+
if (emitted) {
38+
return;
39+
}
40+
emitted = true;
41+
console.log('call');
42+
emit.call(this._editorAdded, args);
43+
};
3144
}
3245

3346
protected async initOnceReady(): Promise<void> {

packages/jupyterlab-lsp/src/features/symbol.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,10 +274,11 @@ export class SymbolFeature extends Feature {
274274
}
275275
const connection = this.connectionManager.connections.get(
276276
adapter.virtualDocument.uri
277-
)!;
277+
);
278278

279279
if (
280280
!(
281+
connection &&
281282
connection.isReady &&
282283
connection.serverCapabilities.documentSymbolProvider
283284
)

packages/metapackage/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@jupyter-lsp/jupyterlab-lsp-metapackage",
3-
"version": "5.0.3",
3+
"version": "5.1.0",
44
"description": "JupyterLab LSP - Meta Package. All of the packages used by JupyterLab LSP",
55
"homepage": "https://github.com/jupyter-lsp/jupyterlab-lsp",
66
"bugs": {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
""" single source of truth for jupyter_lsp version
22
"""
33

4-
__version__ = "2.2.2"
4+
__version__ = "2.2.3"

0 commit comments

Comments
 (0)