Performance: only check old_mode if needed

krassowski · krassowski · commit 83ce87a4907a · 2020-10-25T12:15:57.000Z
diff --git a/packages/jupyterlab-lsp/src/features/syntax_highlighting.ts b/packages/jupyterlab-lsp/src/features/syntax_highlighting.ts
@@ -77,11 +77,10 @@ export class CMSyntaxHighlighting extends CodeMirrorIntegration {
           continue;
         }
 
-        let old_mode = editor.getOption('mode');
-
         // change the mode if the majority of the code is the foreign code
         if (coverage > this.settings.composite.foreignCodeThreshold) {
           editors_with_current_highlight.add(ce_editor);
+          let old_mode = editor.getOption('mode');
           if (old_mode != mode.mime) {
             editor.setOption('mode', mode.mime);
           }

Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,10 @@ export class CMSyntaxHighlighting extends CodeMirrorIntegration {`
`77`	`77`	`continue;`
`78`	`78`	`}`
`79`	`79`
`80`		`- let old_mode = editor.getOption('mode');`
`81`		`-`
`82`	`80`	`// change the mode if the majority of the code is the foreign code`
`83`	`81`	`if (coverage > this.settings.composite.foreignCodeThreshold) {`
`84`	`82`	`editors_with_current_highlight.add(ce_editor);`
	`83`	`+ let old_mode = editor.getOption('mode');`
`85`	`84`	`if (old_mode != mode.mime) {`
`86`	`85`	`editor.setOption('mode', mode.mime);`
`87`	`86`	`}`