rename jump destination from uri to contents_path throughout

Author: bollwyvl

packages/jupyterlab-go-to-definition/src/jump.ts

@@ -37,5 +37,5 @@ export interface IGlobalJump {
   line: number;
   column: number;
 
-  uri: string;
+  contents_path: string;
 }

packages/jupyterlab-go-to-definition/src/jumpers/jumper.ts

@@ -197,7 +197,7 @@ export abstract class CodeJumper {
   }
 
   public global_jump(position: IGlobalJump, is_symlink = false) {
-    let document_widget = this.document_manager.openOrReveal(position.uri);
+    let document_widget = this.document_manager.openOrReveal(position.contents_path);
 
     document_widget.revealed
       .then(() => {
@@ -285,7 +285,7 @@ export abstract class CodeJumper {
               editor_index: input_number,
               line: line_number,
               column: column,
-              uri: path
+              contents_path: path
             },
             is_symlink
           );

packages/jupyterlab-lsp/src/features/jump_to.ts

@@ -22,6 +22,7 @@ import { IDocumentManager } from '@jupyterlab/docmanager';
 import { ILSPAdapterManager, ILSPFeatureManager, PLUGIN_ID } from '../tokens';
 import { LabIcon } from '@jupyterlab/ui-components';
 import jumpToSvg from '../../style/icons/jump-to.svg';
+import { URLExt } from '@jupyterlab/coreutils';
 
 export const jumpToIcon = new LabIcon({
   name: 'lsp:jump-to',
@@ -128,14 +129,14 @@ export class CMJumpToDefinition extends CodeMirrorIntegration {
             content: false
           }
         );
-        this.jumper.global_jump({ uri: contents_path, ...jump_data }, false);
+        this.jumper.global_jump({ contents_path, ...jump_data }, false);
         return;
       } catch (err) {
         console.warn(err);
       }
 
       this.jumper.global_jump(
-        { uri: '.lsp_symlink/' + contents_path, ...jump_data },
+        { contents_path: URLExt.join('.lsp_symlink', contents_path), ...jump_data },
         true
       );
     }