Merge pull request #300 from bollwyvl/gh-299-no-throw

stop using throw

Author: krassowski

CHANGELOG.md

@@ -1,5 +1,14 @@
 ## CHANGELOG
 
+### `@krassowski/jupyterlab-lsp 1.1.1` (unreleased)
+
+- bug fixes
+
+  - emits console warnings instead of throwing errors in hover handlers and connections ([#299][], [#300][])
+
+[#299]: https://github.com/krassowski/jupyterlab-lsp/pull/299
+[#300]: https://github.com/krassowski/jupyterlab-lsp/pull/300
+
 ### `jupyter-lsp 0.9.x` (unreleased)
 
 - autodetects the `texlab` language server for `.tex` files ([#288][])

packages/jupyterlab-lsp/src/adapters/codemirror/features/hover.ts

@@ -201,7 +201,7 @@ export class Hover extends CodeMirrorLSPFeature {
           e.message === "Cannot read property 'string' of undefined"
         )
       ) {
-        throw e;
+        console.warn(e);
       }
     }
   };

packages/jupyterlab-lsp/src/command_manager.ts

@@ -201,7 +201,7 @@ export class NotebookCommandManager extends ContextCommandManager {
     return notebook_adapters.get(notebook.id);
   }
 
-  context_from_active_document(): ICommandContext {
+  context_from_active_document(): ICommandContext | null {
     if (!this.is_widget_current) {
       return null;
     }
@@ -213,7 +213,7 @@ export class NotebookCommandManager extends ContextCommandManager {
 
     let virtual_editor = this.current_adapter?.virtual_editor;
 
-    if (!virtual_editor) {
+    if (virtual_editor == null) {
       return null;
     }
 
@@ -222,6 +222,11 @@ export class NotebookCommandManager extends ContextCommandManager {
       cm_cursor
     );
 
+    if (root_position == null) {
+      console.warn('Could not retrieve current context', virtual_editor);
+      return null;
+    }
+
     return this.current_adapter?.get_context(root_position);
   }
 }

packages/jupyterlab-lsp/src/manager.ts

@@ -53,7 +53,8 @@ export class LanguageServerManager implements ILanguageServerManager {
     );
 
     if (!response.ok) {
-      throw new Error(response.statusText);
+      console.error('Could not fetch sessions', response);
+      return;
     }
 
     let sessions: SCHEMA.Sessions;

packages/jupyterlab-lsp/src/virtual/editors/notebook.ts

@@ -118,11 +118,12 @@ export class VirtualEditorForNotebook extends VirtualEditor {
   transform_from_notebook_to_root(
     cell: Cell,
     position: IEditorPosition
-  ): IRootPosition {
+  ): IRootPosition | null {
     // TODO: if cell is not known, refresh
     let shift = this.cell_to_corresponding_source_line.get(cell);
-    if (shift === undefined) {
-      throw Error('Cell not found in cell_line_map');
+    if (shift == null) {
+      console.warn('Cell not found in cell_line_map');
+      return null;
     }
     return {
       ...(position as CodeMirror.Position),

packages/lsp-ws-connection/src/server-capability-registration.ts

@@ -11,7 +11,7 @@ interface IFlexibleServerCapabilities extends ServerCapabilities {
 function registerServerCapability(
   serverCapabilities: ServerCapabilities,
   registration: Registration
-): ServerCapabilities {
+): ServerCapabilities | null {
   const serverCapabilitiesCopy = JSON.parse(
     JSON.stringify(serverCapabilities)
   ) as IFlexibleServerCapabilities;
@@ -27,7 +27,8 @@ function registerServerCapability(
       );
     }
   } else {
-    throw new Error('Could not register server capability.');
+    console.warn('Could not register server capability.', registration);
+    return null;
   }
 
   return serverCapabilitiesCopy;

packages/lsp-ws-connection/src/ws-connection.ts

@@ -79,10 +79,14 @@ export class LspWsConnection extends events.EventEmitter
           (params: protocol.RegistrationParams) => {
             params.registrations.forEach(
               (capabilityRegistration: protocol.Registration) => {
-                this.serverCapabilities = registerServerCapability(
-                  this.serverCapabilities,
-                  capabilityRegistration
-                );
+                try {
+                  this.serverCapabilities = registerServerCapability(
+                    this.serverCapabilities,
+                    capabilityRegistration
+                  );
+                } catch (err) {
+                  console.error(err);
+                }
               }
             );