Skip to content

Commit 953ae9e

Browse files
committed
bump dependency versions, fix new lint guidance
1 parent 80459bf commit 953ae9e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+1493
-1501
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,6 @@ atest/output/
113113
junit.xml
114114
coverage/
115115
.vscode/
116-
_schema.d.ts
116+
_*.d.ts
117117
_build
118118
.virtual_documents/

atest/07_Configuration.robot

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ Python
1414

1515
YAML
1616
[Documentation] EXPECT FAIL Composer YAML files don't allow a "greetings" key
17-
[Tags] expect:fail
1817
Settings Should Change Editor Diagnostics YAML example.yaml yaml-language-server
1918
... {"yaml.schemas": {"http://json.schemastore.org/composer": "*"}}
2019
... duplicate key

atest/ports.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55

66
def get_unused_port():
7-
""" Get an unused port by trying to listen to any random port.
7+
"""Get an unused port by trying to listen to any random port.
88
9-
Probably could introduce race conditions if inside a tight loop.
9+
Probably could introduce race conditions if inside a tight loop.
1010
"""
1111
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
1212
sock.bind(("localhost", 0))

docs/Language Servers.ipynb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"\n",
4343
"import IPython\n",
4444
"from jinja2 import Template\n",
45+
"\n",
4546
"from jupyter_lsp import LanguageServerManager"
4647
]
4748
},

docs/conf.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@
102102

103103

104104
def setup(app):
105-
""" Runs before the "normal business" of sphinx. Don't go too crazy here.
106-
"""
105+
"""Runs before the "normal business" of sphinx. Don't go too crazy here."""
107106
app.add_css_file("css/custom.css")
108107
subprocess.check_call(["jlpm", "--ignore-optional"])

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"dependencies": {},
33
"devDependencies": {
4-
"@typescript-eslint/eslint-plugin": "^2.27.0",
5-
"@typescript-eslint/parser": "^2.27.0",
4+
"@typescript-eslint/eslint-plugin": "^3.10.1",
5+
"@typescript-eslint/parser": "^3.10.1",
66
"bash-language-server": "^1.6.1",
77
"dictionary-en": "^3.0.0",
88
"dockerfile-language-server-nodejs": "^0.0.22",
9-
"eslint": "^6.8.0",
9+
"eslint": "^7.5.0",
1010
"eslint-config-prettier": "^6.7.0",
1111
"eslint-plugin-import": "^2.22.0",
1212
"eslint-plugin-jest": "^23.8.2",
@@ -17,14 +17,14 @@
1717
"jest-github-actions-reporter": "^1.0.2",
1818
"lerna": "^3.13.2",
1919
"precise-commits": "^1.0.2",
20-
"prettier": "^2.0.5",
20+
"prettier": "^2.1.2",
2121
"sql-language-server": "^0.11.4",
22-
"typescript": "~3.9.5",
22+
"typescript": "~4.0.2",
2323
"unified-language-server": "^0.3.0",
2424
"vscode-css-languageserver-bin": "^1.4.0",
2525
"vscode-html-languageserver-bin": "^1.4.0",
2626
"vscode-json-languageserver-bin": "^1.0.1",
27-
"yaml-language-server": "~0.4.0"
27+
"yaml-language-server": "^0.11.1"
2828
},
2929
"husky": {
3030
"hooks": {}

packages/.eslintrc.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,18 @@ module.exports = {
2121
'**/_*.ts',
2222
'**/_*.d.ts',
2323
'**/typings/**/*.d.ts',
24-
'**/dist/*'
24+
'**/dist/*',
25+
'packages/.eslintrc.js'
2526
],
2627
parser: '@typescript-eslint/parser',
2728
parserOptions: {
2829
project: 'packages/tsconfig.eslint.json'
2930
},
3031
plugins: ['@typescript-eslint', 'jest', 'import'],
3132
rules: {
32-
'@typescript-eslint/ban-ts-ignore': 'warn',
3333
'@typescript-eslint/camelcase': 'off',
3434
'@typescript-eslint/explicit-function-return-type': 'off',
35-
'@typescript-eslint/interface-name-prefix': [
36-
'error',
37-
{ prefixWithI: 'always' }
38-
],
35+
'@typescript-eslint/explicit-module-boundary-types': 'off',
3936
'@typescript-eslint/no-empty-interface': 'off',
4037
'@typescript-eslint/no-explicit-any': 'off',
4138
'@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],

packages/jupyterlab-go-to-definition/src/editors/codemirror/extension.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ function getModifierState(event: MouseEvent, modifierKey: string): boolean {
3232
}
3333
}
3434

35-
export class CodeMirrorExtension extends CodeMirrorTokensProvider
35+
export class CodeMirrorExtension
36+
extends CodeMirrorTokensProvider
3637
implements IEditorExtension {
3738
jumper: CodeJumper;
3839
static modifierKey: KeyModifier;

packages/jupyterlab-go-to-definition/src/jumpers/jumper.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ export abstract class CodeJumper {
358358
}
359359
}
360360

361-
handle_kernel_inspect(response: IIOPubMessage, fallback: Function) {
361+
handle_kernel_inspect(response: IIOPubMessage, fallback: () => void) {
362362
let obj: any = response.content;
363363
if (obj.name === 'stdout') {
364364
let data = JSON.parse(obj.text);
@@ -386,8 +386,8 @@ export abstract class CodeJumper {
386386
protected inspect_and_jump(
387387
context: TokenContext,
388388
cell_of_origin_analyzer: LanguageAnalyzer,
389-
fallback: Function,
390-
callback: Function
389+
fallback: () => void,
390+
callback: () => void
391391
) {
392392
let code = cell_of_origin_analyzer.definitionLocationQuery(context);
393393

packages/jupyterlab-go-to-definition/src/languages/python.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { PathExt } from '@jupyterlab/coreutils';
66
function evaluateSkippingBrackets(
77
tokens: ReadonlyArray<IToken>,
88
indexShift: number,
9-
callback: Function,
9+
callback: (nextToken: CodeEditor.IToken, indexShift: number) => any,
1010
allowNegativeBrackets = false
1111
) {
1212
// here `nextToken` is any token, not necessarily a meaningful one

0 commit comments

Comments
 (0)