slow down on lab startup, pin to lab 4.0.x for now

Author: bollwyvl

.github/workflows/job.test.yml

@@ -43,8 +43,8 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu]
-        nodejs: ['>=16,<17.0.0a0']
-        lab: ['>=4.0.6,<5.0.0a0']
+        nodejs: ['>=20,<21']
+        lab: ['>=4.0.12,<4.1.0a0']
         r: ['>=4']
     steps:
       - uses: actions/checkout@v4
@@ -123,7 +123,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu]
-        nodejs: ['>=16,<17.0.0a0']
+        nodejs: ['>=20,<21']
         lab: ['>=4.0.0,<5.0.0a0']
         r: ['>=4']
     steps:
@@ -220,12 +220,12 @@ jobs:
             # Node 16 end-of-life: 2023-09-11
             nodejs: '>=16,<17.0.0.a0'
             r: '>=4'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - python: '3.11'
             # Node 18 end-of-life: 2025-04-30
             nodejs: '>=18,<19.0.0.a0'
             r: '>=4'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
 
     steps:
       - uses: actions/checkout@v4
@@ -322,15 +322,15 @@ jobs:
 
       - name: Find and remove empty files
         # https://github.com/actions/upload-artifact/issues/150
-        run: find ./atest/output -empty -delete
+        run: find ./build/reports -empty -delete
         if: always()
         shell: bash
 
       - name: Publish browser test output
         uses: actions/upload-artifact@v3
         with:
-          name: ${{ job.status }} Robot ${{ matrix.os }} Python ${{ matrix.python }} ${{ github.run_number }}
-          path: ./atest/output
+          name: Robot ${{ matrix.os }} Python ${{ matrix.python }} ${{ github.run_number }}
+          path: ./build/reports
         if: always()
 
       - name: Rename uncached conda packages
@@ -350,16 +350,16 @@ jobs:
         include:
           - python: '3.8'
             dist: 'jupyter*lsp*.whl'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - python: '3.8'
             dist: 'jupyter*lsp*.tar.gz'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - python: '3.11'
             dist: 'jupyter*lsp*.whl'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - python: 'pypy-3.8'
             dist: 'jupyter*lsp*.tar.gz'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - os: 'windows'
             py_cmd: python
           - os: 'macos'
@@ -402,12 +402,12 @@ jobs:
       matrix:
         os: [ubuntu]
         python: ['3.8', '3.11']
-        nodejs: ['18']
+        nodejs: ['20.x']
         include:
           - python: '3.8'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
           - python: '3.11'
-            lab: '>=4,<5'
+            lab: '>=4.0.12,<5'
     steps:
       - name: Install Python
         uses: actions/setup-python@v4

CONTRIBUTING.md

@@ -32,7 +32,7 @@ Thank you for all your contributions :heart:
 A development environment requires, at a minimum:
 
 - `python >=3.8,<3.13.0a0`
-- `jupyterlab >=4.0.10,<5.0.0a0`
+- `jupyterlab >=4.0.10,<4.1.0a0`
 - `nodejs >=18,!=19,!=21,<23`
 
 It is recommended to use a virtual environment (e.g. `virtualenv` or `conda env`)
@@ -228,17 +228,19 @@ Run the tests:
 python scripts/atest.py
 ```
 
-The Robot Framework reports and screenshots will be in `atest/output`, with
-`<operating system>_<python version>_<attempt>.<log|report>.html` and subsequent `screenshots` being the most interesting
-artifact, e.g.
+The Robot Framework reports and screenshots will be in
+`build/reports/{os}_{py}/atest/{attempt}`, with `(log|report).html` and subsequent
+captured `screenshots` being the most interesting artifact, e.g.
 
 ```
-atest/
-  output/
-    linux_37_1.log.html
-    linux_37_1.report.html
-    linux_37_1/
-      screenshots/
+build/
+  reports/
+    linux_310/
+      atest/
+        1/
+          log.html
+          report.html
+          screenshots/
 ```
 
 #### Customizing the Acceptance Test Run

README.md

@@ -90,7 +90,7 @@ Use context menu on rows in the panel to filter out diagnostics or copy their me
 
 You will need to have both of the following installed:
 
-- JupyterLab >=4.0.6,<5.0.0a0
+- JupyterLab >=4.0.12,<4.1.0a0
 - Python 3.8+
 
 In addition, if you wish to use javascript, html, markdown or any other NodeJS-based language server you will need to have appropriate NodeJS version installed.

atest/_libraries/logcheck.py

@@ -1,5 +1,5 @@
 from bs4 import UnicodeDammit
-
+import time
 
 def file_should_not_contain_phrases(filename, offset=0, *phrases):
     """don't fail _too_ hard if the file can't be read for some reason"""
@@ -26,3 +26,17 @@ def file_should_not_contain_phrases(filename, offset=0, *phrases):
                 matches[phrase] = True
 
         assert not matches, "Phrases found in {}: {}".format(filename, matches)
+
+
+def wait_until_file_contains(filename, *phrases, retries: int=20, interval: float=0.5):
+    for i in range(retries):
+        try:
+            file_should_not_contain_phrases(filename, 0, *phrases)
+            time.sleep(interval)
+        except AssertionError as err:
+            print(err)
+            return True
+
+    raise RuntimeError(
+        f"After {retries*interval}s, {filename} did not contain: {phrases}"
+    )

atest/_resources/Keywords.resource

@@ -35,6 +35,8 @@ Setup Server and Browser
     ...    env:HOME=${HOME}
     ...    env:JUPYTER_NO_CONFIG=${EMPTY}
     Set Global Variable    ${SERVER}    ${server}
+    Wait Until File Contains   ${LAB LOG}
+    ...  The following Language Servers will be available
     Open JupyterLab
     Read Page Config
 

binder/environment.yml

@@ -7,7 +7,7 @@ channels:
 dependencies:
   # runtime dependencies
   - python >=3.8,<3.13.0a0
-  - jupyterlab >=4.0.10,<5.0.0a0
+  - jupyterlab >=4.0.10,<4.1.0a0
   - jupyter_server >=1.1.2
   - notebook >=7
   # build dependencies

docs/rtd.yml

@@ -7,7 +7,7 @@ channels:
 
 dependencies:
   - importlib_metadata
-  - jupyterlab >=4.0.6,<5.0.0a0
+  - jupyterlab >=4.0.10,<4.1.0a0
   - myst-nb
   - nodejs >=18,!=19,!=21,<23
   - pandas

python_packages/jupyterlab_lsp/setup.cfg

@@ -37,4 +37,4 @@ python_requires = >=3.8
 
 install_requires =
     jupyter_lsp >=2.0.0
-    jupyterlab >=4.0.6,<5.0.0a0
+    jupyterlab >=4.0.10,<4.1.0a0

requirements/lab.txt

@@ -1,3 +1,3 @@
 # the version of jupyterlab
 -r ./prod.txt
-jupyterlab >=4.0.6,<5.0.0a0
+jupyterlab >=4.0.10,<4.1.0a0