Merge pull request #504 from jtpio/notebook-server

Add config for the classic notebook server extension

Author: krassowski

.github/workflows/job.test.yml

@@ -313,7 +313,14 @@ jobs:
         run: python -m pip check
 
       - name: List server extensions
-        run: jupyter server extension list
+        run: |
+          jupyter server extension list
+          jupyter server extension list 2>&1 | grep -ie "jupyter_lsp.*enabled" -
+
+      - name: List notebook server extensions
+        run: |
+          jupyter serverextension list
+          jupyter serverextension list 2>&1 | grep -ie "jupyter_lsp.*enabled" -
 
       - name: List frontend extensions
         run: jupyter labextension list

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## CHANGELOG
 
+### `jupyter-lsp 1.1.3` (unreleased)
+
+- features:
+
+  - add config for the classic notebook server extension ([#504])
+
 ### `@krassowski/jupyterlab-lsp 3.3.0` (2021-01-31)
 
 - features:

binder/postBuild

@@ -20,4 +20,5 @@ popd
 
 # List extensions
 jupyter serverextension list
+jupyter server extension list
 jupyter labextension list

python_packages/jupyter_lsp/jupyter_lsp/etc/jupyter_notebook_config.json

@@ -0,0 +1,7 @@
+{
+  "NotebookApp": {
+    "nbserver_extensions": {
+      "jupyter_lsp": true
+    }
+  }
+}

python_packages/jupyter_lsp/jupyter_lsp/etc/jupyter-lsp.json renamed to python_packages/jupyter_lsp/jupyter_lsp/etc/jupyter_server_config.json

@@ -15,7 +15,11 @@
     data_files=[
         (
             "etc/jupyter/jupyter_server_config.d",
-            ["jupyter_lsp/etc/jupyter-lsp.json"],
+            ["jupyter_lsp/etc/jupyter_server_config.json"],
+        ),
+        (
+            "etc/jupyter/jupyter_notebook_config.d",
+            ["jupyter_lsp/etc/jupyter_notebook_config.json"],
         )
     ],
 )