Merge pull request #434 from krassowski/fix-autoinvoke-on-dot

Ensure that trigger characters auto-invoke works with continuous hinting

Author: krassowski

CHANGELOG.md

@@ -5,8 +5,10 @@
 - bug fixes
   - improved performance of completion and highlights by minimising the number of highlight requests and GUI redraws (token checking, debouncing, acting on a single response only) ([#433])
   - highlights now update after cell focus/blur events even if those do not trigger cursor movement ([#433])
+  - trigger characters auto-invoke now works in continuous hinting mode again ([#434])
 
 [#433]: https://github.com/krassowski/jupyterlab-lsp/issues/433
+[#434]: https://github.com/krassowski/jupyterlab-lsp/issues/434
 
 ### `@krassowski/jupyterlab-lsp 2.1.1` (2020-12-15)
 

atest/05_Features/Completion.robot

@@ -54,6 +54,9 @@ Continious Hinting Works
     Capture Page Screenshot    01-editor-ready.png
     Press Keys    None    d
     Completer Should Suggest    addition
+    # gh430 - auto invoke after dot should work too
+    Press Keys    None    .
+    Completer Should Suggest    __doc__
 
 Autocompletes If Only One Option
     Enter Cell Editor    3    line=1

packages/jupyterlab-lsp/src/features/completion/completion.ts

@@ -44,17 +44,10 @@ export class CompletionCM extends CodeMirrorIntegration {
   afterChange(change: CodeMirror.EditorChange): void {
     // TODO: maybe the completer could be kicked off in the handleChange() method directly; signature help still
     //  requires an up-to-date virtual document on the LSP side, so we need to wait for sync.
-    if (
-      change.text &&
-      change.text[0].length == 1 &&
-      this.settings.composite.continuousHinting
-    ) {
-      (this.feature.labIntegration as CompletionLabIntegration)
-        .invoke_completer(AdditionalCompletionTriggerKinds.AutoInvoked)
-        .catch(console.warn);
-      return;
-    }
 
+    // note: trigger character completion need to be have a higher priority than auto-invoked completion
+    // because the latter does not work for on-dot completion due to suppression of trivial suggestions
+    // see gh430
     let last_character = this.extract_last_character(change);
     if (this.completionCharacters.indexOf(last_character) > -1) {
       this.virtual_editor.console.log(
@@ -64,6 +57,17 @@ export class CompletionCM extends CodeMirrorIntegration {
       (this.feature.labIntegration as CompletionLabIntegration)
         .invoke_completer(CompletionTriggerKind.TriggerCharacter)
         .catch(console.warn);
+      return;
+    }
+
+    if (
+      change.text &&
+      change.text[0].length == 1 &&
+      this.settings.composite.continuousHinting
+    ) {
+      (this.feature.labIntegration as CompletionLabIntegration)
+        .invoke_completer(AdditionalCompletionTriggerKinds.AutoInvoked)
+        .catch(console.warn);
     }
   }
 }