Configure using server spec rather than language name

Author: Travis James Smith

packages/jupyterlab-lsp/src/connection_manager.ts

@@ -8,7 +8,6 @@ import { sleep, until_ready } from './utils';
 // Name-only import so as to not trigger inclusion in main bundle
 import * as ConnectionModuleType from './connection';
 import { TLanguageServerId, ILanguageServerManager } from './tokens';
-import { ClientConfigurationSchema } from './_schema'
 
 export interface IDocumentConnectionData {
   virtual_document: VirtualDocument;
@@ -131,7 +130,7 @@ export class DocumentConnectionManager {
     const language_server_id = this.language_server_manager.getServerId({
       language
     });
-
+    console.log("LS ID: ", language_server_id)
     // lazily load 1) the underlying library (1.5mb) and/or 2) a live WebSocket-
     // like connection: either already connected or potentiailly in the process
     // of connecting.
@@ -151,15 +150,12 @@ export class DocumentConnectionManager {
 
   public async updateServerConfigurations(
     //TODO: define types for server configurations
-    options: any
+    settings: any
   ) {
-    for (let language in options) {
-      let connection = this.connections.get(language)
-
-      if (connection) {
-        const config = options[language].config
-        await connection.sendConfigurationChange(config)
-      }
+    console.log(this.language_server_manager)
+    for (let language_server_id in settings) {
+      const config = settings[language_server_id].config
+      await Private.updateServerConfiguration(language_server_id, config)
     }
   }
 
@@ -263,7 +259,6 @@ export class DocumentConnectionManager {
     }
   }
 
-  // Travis: per language configuration here?
   async connect(options: ISocketConnectionOptions) {
     console.log('LSP: connection requested', options);
     let connection = await this.connect_socket(options);
@@ -389,4 +384,14 @@ namespace Private {
 
     return connection;
   }
+
+  export async function updateServerConfiguration(
+    language_server_id: any,
+    settings: any
+  ): Promise<any> {
+    const connection = _connections.get(language_server_id)
+    if (connection) {
+      await connection.sendConfigurationChange(settings)
+    }
+  }
 }

packages/jupyterlab-lsp/src/index.ts

@@ -235,6 +235,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
     notebook_command_manager.add(lsp_commands);
 
     function updateOptions(settings: ISettingRegistry.ISettings): void {
+      console.log(connection_manager)
       const options = settings.composite;
 
       // Object.keys(options).forEach((key) => {