Merge branch 'master' into add-dot-local-node-root

Author: krassowski

.github/workflows/job.test.yml

@@ -228,8 +228,8 @@ jobs:
         include:
           # if using 3.7, use newer node, etc...
           - python: '3.7'
-            # Node 12 end-of-life: April 2022
-            nodejs: '>=12,<13.0.0.a0'
+            # Node 14 end-of-life: April 2023
+            nodejs: '>=14,<15.0.0.a0'
             r: '<4'
             lab: '>=3.1.0,<3.2'
           - python: '3.10'

CONTRIBUTING.md

@@ -31,7 +31,7 @@ Thank you for all your contributions :heart:
 
 Development requires, at a minimum:
 
-- `nodejs >=12,!=13,!=15,<17`
+- `nodejs >=14,!=15,<17`
 - `python >=3.7,<3.11.0a0`
   - Python 3.7 and 3.10 are fully tested on CI
   - Python 3.7 to 3.10 and PyPy 3 are verified to at least install and import

README.md

@@ -128,7 +128,6 @@ Use of a python `virtualenv` or a conda env is also recommended.
    R ([languageserver](https://github.com/REditorSupport/languageserver)) servers:
 
    ```bash
-   # note: you may want to use our fork of python-language-server instead (see below)
    pip install 'python-lsp-server[all]'
    R -e 'install.packages("languageserver")'
    ```
@@ -164,8 +163,6 @@ Use of a python `virtualenv` or a conda env is also recommended.
 
    or permanently by setting `c.Completer.use_jedi = False` in your
    [`ipython_config.py` file](https://ipython.readthedocs.io/en/stable/config/intro.html?highlight=ipython_config.py#systemwide-configuration).
-   You will also benefit from using experimental version of python-language-server
-   as described in the Note 2 (above).
 
 1. (Optional, Linux/OSX-only) to enable opening files outside of the root
    directory (the place where you start JupyterLab), create `.lsp_symlink` and

atest/05_Features/Completion.robot

@@ -12,7 +12,7 @@ Force Tags          feature:completion
 ${COMPLETER_BOX}            css:.jp-Completer.jp-HoverBox
 ${DOCUMENTATION_PANEL}      css:.jp-Completer-docpanel
 ${KERNEL_BUSY_INDCA_OLD}    css:.jp-NotebookPanel-toolbar div[title="Kernel Busy"]
-${KERNEL_BUSY_INDICATOR}    css:.jp-Notebook-ExecutionIndicator div[data-status="busy"]
+${KERNEL_BUSY_INDICATOR}    css:.jp-Notebook-ExecutionIndicator[data-status="busy"]
 
 
 *** Test Cases ***

atest/07_Configuration.robot

@@ -76,8 +76,11 @@ Settings Should Change Editor Diagnostics
     Capture Page Screenshot    03-settings-changed.png
     IF    ${needs reload}
         Reload After Configuration    ${language}    ${file}
+        # allow longer after reload
+        Wait Until Page Contains Element    ${after diagnostic}    timeout=60s
+    ELSE
+        Wait Until Page Contains Element    ${after diagnostic}    timeout=30s
     END
-    Wait Until Page Contains Element    ${after diagnostic}    timeout=30s
     Capture Page Screenshot    04-configured-diagnostic-found.png
     [Teardown]    Clean Up After Working with File and Settings    ${file}
 

atest/Variables.resource

@@ -29,8 +29,8 @@ ${CSS DIALOG OK}                css:.jp-Dialog .jp-mod-accept
 ${MENU OPEN WITH}               xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "Open With")]
 # R is missing on purpose (may need to use .)
 ${MENU RENAME}                  xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(., "ename")]
-# N is missing on purpose
-${MENU NOTEBOOK}                xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(., "otebook")]
+# N is missing on purpose (N is in separate <span>)
+${MENU NOTEBOOK}                xpath://li[@data-command='filebrowser:open']/div[contains(@class, 'lm-Menu-itemLabel')][contains(., "otebook")]
 ${DIAGNOSTICS PANEL}            id:lsp-diagnostics-panel
 ${DIAGNOSTIC PANEL CLOSE}       css:.lm-DockPanel-tabBar .lm-TabBar-tab[data-id="lsp-diagnostics-panel"] .lm-TabBar-tabCloseIcon
 ${DIALOG WINDOW}                css:.jp-Dialog

binder/environment.yml

@@ -11,7 +11,7 @@ dependencies:
   - jupyter_server >=1.1.2
   - retrolab >=0.3.0,<0.4
   # build dependencies
-  - nodejs >=12,!=13,!=15,<17
+  - nodejs >=14,!=15,<17
   # for python language server (and development)
   - flake8 >=3.5
   - pip

docs/Language Servers.ipynb

@@ -225,7 +225,7 @@
     "servers; you can get it with:\n",
     "\n",
     "```bash\n",
-    "conda install -c conda-forge nodejs\n",
+    "conda install --channel conda-forge nodejs\n",
     "# or one of the following, as an administrator\n",
     "choco install nodejs            # Windows with Chocolatey\n",
     "sudo apt-get install nodejs     # Debian/Ubuntu\n",
@@ -318,7 +318,7 @@
     "#### Example: Getting a $\\LaTeX$ stack\n",
     "\n",
     "```bash\n",
-    "conda install -y conda-forge tectonic texlab chktex\n",
+    "conda install --channel conda-forge tectonic texlab chktex\n",
     "```\n",
     "\n",
     "This will install:\n",

docs/rtd.yml

@@ -9,7 +9,7 @@ dependencies:
   - importlib_metadata
   - jupyterlab >=3.1.0,<4.0.0a0
   - myst-nb
-  - nodejs >=12,!=13,!=15,<17
+  - nodejs >=14,!=15,<17
   - pandas
   - pip
   - pytest-check-links