Try looking for a Warning instead of an Error in the acceptance test

Author: trajamsmith

atest/05_Features/Configuration.robot

@@ -8,12 +8,12 @@ Resource          ../Keywords.robot
 ${CONFIG PYLS}    {"language_servers": {"pyls": {"serverSettings": {"pyls": {"plugins": {"flake8": {"enabled": true},"pyflakes": {"enabled": false}}}}}}}
 # pyflakes is enabled by default, but flake8 is not
 ${PYFLAKES DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="undefined name 'foo' (pyflakes)"]
-${FLAKE8 DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="undefined name 'foo' (flake8)"]
+${FLAKE8 DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Warning[title="undefined name 'foo' (flake8)"]
 
-${CONFIG YAML SCHEMA}    {"language_servers": {"yaml-language-server": {"serverSettings": {"yaml.schemas": {"http://json.schemastore.org/composer": "*"}}}}}
-${YAML DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="duplicate key"]
-# TODO: fix this for the actual schema error to expect
-${SCHEMA DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="TODO: schema error here"]
+# ${CONFIG YAML SCHEMA}    {"language_servers": {"yaml-language-server": {"serverSettings": {"yaml.schemas": {"http://json.schemastore.org/composer": "*"}}}}}
+# ${YAML DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="duplicate key"]
+# # TODO: fix this for the actual schema error to expect
+# ${SCHEMA DIAGNOSTIC}    ${CSS DIAGNOSTIC}-Error[title="TODO: schema error here"]
 
 *** Test Cases ***
 Pyls Configuration
@@ -24,12 +24,15 @@ Pyls Configuration
     Open Diagnostics Panel
     Drag and Drop By Offset    ${JLAB XP DOCK TAB}\[contains(., 'Diagnostics Panel')]    600    -200
     Capture Page Screenshot    01-diagnostics-and-settings.png
+    # Diagnostic panel should show pyflakes diagnostics, but no flake8
     Wait Until Page Contains Element    ${PYFLAKES DIAGNOSTIC}    timeout=20s
     Page Should Not Contain    ${FLAKE8 DIAGNOSTIC}
     Set Editor Content    ${CONFIG PYLS}    ${CSS USER SETTINGS}
     Click Element    css:button[title\='Save User Settings']
     Capture Page Screenshot    02-settings-changed.png
+    # After updating settings, we should see flake8 but no pyflakes
     Wait Until Page Contains Element    ${FLAKE8 DIAGNOSTIC}    timeout=20s
+    Page Should Not Contain    ${PYFLAKES DIAGNOSTIC}
     Capture Page Screenshot    03-schema-diagnostic-found.png
     [Teardown]    Clean Up After Working with File and Settings    ${file}
 

packages/jupyterlab-lsp/schema/plugin.json

@@ -5,7 +5,7 @@
   "properties": {
     "language_servers": {
       "title": "Language Server",
-      "description": "Language-server specific configuration, keyed by implementation, e.g: \n\npyls: {\n  serverSettings: {\n    pyls: {\n      plugins: {\n        pydocstyle: {\n          enabled: true\n        },\n        pyflakes: {\n          enabled: false\n        },\n        flake8: {\n          enabled: true\n        }\n      }\n    }\n  }\n}\n\nAlternatively, using VSCode's naming convention:\n\npyls: {\n  serverSettings: {\n    pyls.plugins.pydocstyle.enabled: true,\n    pyls.plugins.pyflakes.enabled: false,\n    pyls.plugins.flake8.enabled: true\n  }\n}",
+      "description": "Language-server specific configuration, keyed by implementation, e.g: \n\npyls: {\n  serverSettings: {\n    pyls: {\n      plugins: {\n        pydocstyle: {\n          enabled: true\n        },\n        pyflakes: {\n          enabled: false\n        },\n        flake8: {\n          enabled: true\n        }\n      }\n    }\n  }\n}\n\nAlternatively, using VSCode's naming convention:\n\npyls: {\n  serverSettings: {\n    \"pyls.plugins.pydocstyle.enabled\": true,\n    \"pyls.plugins.pyflakes.enabled\": false,\n    \"pyls.plugins.flake8.enabled\": true\n  }\n}",
       "type": "object",
       "default": {},
       "patternProperties": {