restore interface name eslint rule, grandfather in VirtualEditor

Author: bollwyvl

packages/.eslintrc.js

@@ -20,42 +20,46 @@ module.exports = {
     '**/lib/**/*',
     '**/_*.ts',
     '**/_*.d.ts',
-    '**/typings/**/*.d.ts'
+    '**/typings/**/*.d.ts',
+    '**/dist/*'
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     project: 'packages/tsconfig.eslint.json'
   },
   plugins: ['@typescript-eslint', 'jest'],
   rules: {
-    '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
-    '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
-    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/ban-ts-ignore': 'warn',
     '@typescript-eslint/camelcase': 'off',
-    '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-non-null-assertion': 'off',
-    '@typescript-eslint/no-namespace': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/ban-ts-ignore': 'warn',
-    '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/interface-name-prefix': [
+      'error',
+      { prefixWithI: 'always' }
+    ],
     '@typescript-eslint/no-empty-interface': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
     '@typescript-eslint/no-inferrable-types': 'off',
+    '@typescript-eslint/no-namespace': 'off',
+    '@typescript-eslint/no-non-null-assertion': 'off',
+    '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/no-var-requires': 'off',
+    'jest/expect-expect': 'off',
+    'jest/no-export': 'warn',
+    'jest/no-jest-import': 'off',
+    'jest/no-try-expect': 'warn',
+    'no-case-declarations': 'warn',
+    'no-control-regex': 'warn',
     'no-inner-declarations': 'off',
     'no-prototype-builtins': 'off',
-    'no-control-regex': 'warn',
     'no-undef': 'warn',
-    'no-case-declarations': 'warn',
     'no-useless-escape': 'off',
     'prefer-const': 'off',
-    'jest/no-jest-import': 'off',
-    'jest/no-export': 'warn',
-    'jest/no-try-expect': 'warn',
-    'jest/expect-expect': 'off',
     // deviations from jupyterlab, should probably be fixed
     'jest/valid-expect': 'off',
     'jest/no-test-callback': 'off',
     '@typescript-eslint/ban-ts-ignore': 'off',
-    '@typescript-eslint/interface-name-prefix': 'off',
     'react/display-name': 'off',
     'prefer-spread': 'off',
     '@typescript-eslint/triple-slash-reference': 'off',

packages/jupyterlab-lsp/src/virtual/editor.ts

@@ -253,4 +253,4 @@ export abstract class VirtualEditor implements CodeMirror.Editor {
   }
 }
 
-export interface VirtualEditor extends CodeMirror.Editor {}
+export interface VirtualEditor extends CodeMirror.Editor {} // eslint-disable-line @typescript-eslint/interface-name-prefix