Merge pull request #291 from krassowski/krassowski-lint-ci-isort-pin-5

Pin isort to restore the lint step in CI

Author: krassowski

binder/environment.yml

@@ -14,7 +14,10 @@ dependencies:
   # for python language server (and development)
   - black
   - flake8 >=3.5
-  - isort
+  # isort 5.0 has breaking API changes which affect (among others) pylint and nblint;
+  # the pin should be removed once https://github.com/PyCQA/pylint/pull/3725 is merged
+  # see https://github.com/krassowski/jupyterlab-lsp/pull/291
+  - isort <5
   - mypy
   - pip
   - pylint

requirements/lint.yml

@@ -6,7 +6,10 @@ channels:
 
 dependencies:
   - black
-  - isort
+  # isort 5.0 has breaking API changes which affect (among others) pylint and nblint;
+  # the pin should be removed once https://github.com/PyCQA/pylint/pull/3725 is merged
+  # see https://github.com/krassowski/jupyterlab-lsp/pull/291
+  - isort <5
   - mypy
   - robotframework-lint >=1.1
   - robotframework >=3.2