Merge pull request #697 from jupyter-lsp/update-typescript-server

Migrate to typescript-language-server

Author: krassowski

atest/01_Editor.robot

@@ -61,7 +61,7 @@ SCSS
 
 TSX
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-tag')][contains(text(), 'HelloWorld')])[last()]
-    Editor Shows Features for Language    TSX    example.tsx    Diagnostics=Cannot find module 'react'    Jump to Definition=${def}    Rename=${def}
+    Editor Shows Features for Language    TSX    example.tsx    Diagnostics='hello' is declared but its value is never read.    Jump to Definition=${def}    Rename=${def}
 
 TypeScript
     ${def} =    Set Variable    xpath:(//span[contains(@class, 'cm-variable')][contains(text(), 'inc')])[last()]

atest/05_Features/Completion.robot

@@ -60,7 +60,7 @@ Invalidates On Cell Change
 Invalidates On Focus Loss
     Enter Cell Editor    1    line=2
     Press Keys    None    TAB
-    Click JupyterLab Menu      File
+    Click JupyterLab Menu    File
     # just to increase chances of catching this on CI (which is slow)
     Sleep    4s
     Completer Should Not Suggest    test

atest/05_Features/Hover.robot

@@ -42,7 +42,7 @@ Hover works in foreign code (javascript)
     # also for multiple cells of the same document
     Enter Cell Editor    3
     Trigger Tooltip    Math
-    Element Should Contain    ${HOVER_BOX}    const Math: Math
+    Element Should Contain    ${HOVER_BOX}    Math: Math
 
 *** Keywords ***
 Last Occurrence

atest/Keywords.robot

@@ -324,7 +324,7 @@ Wait Until Fully Initialized
     Wait Until Element Contains    ${STATUSBAR}    Fully initialized    timeout=60s
 
 Wait For Ready State
-    Wait For Condition                 return document.readyState=="complete"
+    Wait For Condition    return document.readyState=="complete"
 
 Open Context Menu Over
     [Arguments]    ${sel}

atest/examples/example.tsx

@@ -7,5 +7,3 @@ export class HelloWorld extends React.Component<any, any> {
 }
 
 const hello = <HelloWorld/>;
-
-;hello;

docs/Extending.ipynb

@@ -238,8 +238,8 @@
     "    {\n",
     "      'all_listeners': ['some.module.some_function'],\n",
     "      'client_listeners': ['some.module.some_other_function'],\n",
-    "      'server_listeners': ['some.module.yet_another_function'],\n",
-    "    },\n",
+    "      'server_listeners': ['some.module.yet_another_function']\n",
+    "    }\n",
     "}\n",
     "```"
    ]

docs/Language Servers.ipynb

@@ -250,7 +250,7 @@
     "    vscode-css-languageserver-bin \\\n",
     "    dockerfile-language-server-nodejs \\\n",
     "    vscode-html-languageserver-bin \\\n",
-    "    javascript-typescript-langserver \\\n",
+    "    typescript-language-server \\\n",
     "    vscode-json-languageserver-bin \\\n",
     "    yaml-language-server\n",
     "```\n",
@@ -374,4 +374,4 @@
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}

docs/Roadmap.ipynb

@@ -35,8 +35,8 @@
    "source": [
     "### Backend\n",
     "\n",
-    "- [#49](https://github.com/jupyter-lsp/jupyterlab-lsp/issues/49) cookiecutter for\n",
-    "  pip-installable specs\n",
+    "- [#49](https://github.com/jupyter-lsp/jupyterlab-lsp/issues/49) cookiecutter\n",
+    "  for pip-installable specs\n",
     "- add hook system to allow serverextensions/kernels to modify, inspect and react\n",
     "  to LSP messages"
    ]

package.json

@@ -13,7 +13,7 @@
     "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-react": "^7.21.5",
     "husky": "^3.0.9",
-    "javascript-typescript-langserver": "^2.11.3",
+    "typescript-language-server": "^0.6.4",
     "jest-github-actions-reporter": "^1.0.2",
     "lerna": "^3.13.2",
     "npm-run-all": "^4.1.5",

python_packages/jupyter_lsp/jupyter_lsp/specs/__init__.py

@@ -13,6 +13,7 @@
 from .r_languageserver import RLanguageServer
 from .sql_language_server import SQLLanguageServer
 from .texlab import Texlab
+from .typescript_language_server import TypescriptLanguageServer
 from .unified_language_server import UnifiedLanguageServer
 from .vscode_css_languageserver import VSCodeCSSLanguageServer
 from .vscode_html_languageserver import VSCodeHTMLLanguageServer
@@ -32,6 +33,7 @@
 pyright = PyrightLanguageServer()
 r = RLanguageServer()
 tex = Texlab()
-ts = JavascriptTypescriptLanguageServer()
+ts_old = JavascriptTypescriptLanguageServer()
+ts = TypescriptLanguageServer()
 sql = SQLLanguageServer()
 yaml = YAMLLanguageServer()