restore bash-language-server highlighting default

Author: bollwyvl

atest/03_Notebook.robot

@@ -14,12 +14,12 @@ Python
 Foreign Extractors
     ${file} =    Set Variable    Foreign extractors.ipynb
     Configure JupyterLab Plugin
-    ...    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}}}
+    ...    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}, "bash-langauge-server": {"bashIde.highlightParsingErrors": true}}}
     Capture Page Screenshot    10-configured.png
     Reset Application State
     Setup Notebook    Python    ${file}
     @{diagnostics} =    Create List
-    ...    Failed to parse expression    # bash
+    ...    Failed to parse expression    # bash, configured by spec.env
     ...    ame 'valid'    # python, mypy and pyflakes will fight over `(N|n)ame 'valid'`, just hope for the best
     ...    Trailing whitespace is superfluous.    # r
     ...    `frob` is misspelt    # markdown

py_src/jupyter_lsp/specs/bash_language_server.py

@@ -1,6 +1,7 @@
 from .config import load_config_schema
 from .utils import NodeModuleSpec
 
+import os
 
 class BashLanguageServer(NodeModuleSpec):
     node_module = key = "bash-language-server"
@@ -20,4 +21,8 @@ class BashLanguageServer(NodeModuleSpec):
             jlpm="jlpm add --dev {}".format(key),
         ),
         config_schema=load_config_schema(key),
+        # required as of bash-language-server 1.17.0, can't be configured. sigh.
+        env=dict(
+            HIGHLIGHT_PARSING_ERRORS=os.environ.get("HIGHLIGHT_PARSING_ERRORS", "true")
+        )
     )