Skip to content

Commit c294c2c

Browse files
committed
Attempt to improve robustness and speed of CI tests
1 parent 4fee513 commit c294c2c

File tree

5 files changed

+14
-15
lines changed

5 files changed

+14
-15
lines changed

atest/01_Editor.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ${CM CURSORS} css:.CodeMirror-cursors:not([style='visibility: hidden'])
1212
*** Test Cases ***
1313
Bash
1414
[Documentation] TODO: figure out why the first server is extra flaky
15-
Wait Until Keyword Succeeds 3x 10s Editor Shows Features for Language Bash example.sh Diagnostics=Failed to parse expression
15+
Wait Until Keyword Succeeds 6x 5s Editor Shows Features for Language Bash example.sh Diagnostics=Failed to parse expression
1616
... Jump to Definition=fib
1717

1818
CSS

atest/03_Notebook.robot

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ Resource Keywords.robot
44

55
*** Test Cases ***
66
Python
7-
[Setup] Reset Application State
7+
[Setup] Gently Reset Workspace
88
Setup Notebook Python Python.ipynb
99
Capture Page Screenshot 01-python.png
1010
${diagnostic} = Set Variable W291 trailing whitespace (pycodestyle)
11-
Wait Until Page Contains Element css:.cm-lsp-diagnostic[title="${diagnostic}"] timeout=20s
11+
Wait Until Page Contains Element css:.cm-lsp-diagnostic[title="${diagnostic}"] timeout=35s
1212
Capture Page Screenshot 02-python.png
1313
Clean Up After Working With File Python.ipynb
1414

1515
Foregin Extractors
16-
[Setup] Reset Application State
16+
[Setup] Gently Reset Workspace
1717
Setup Notebook Python Foreign extractors.ipynb
1818
@{diagnostics} = Create List Failed to parse expression undefined name 'valid' (pyflakes) Trailing whitespace is superfluous. (lintr)
1919
FOR ${diagnostic} IN @{diagnostics}
20-
Wait Until Page Contains Element css:.cm-lsp-diagnostic[title="${diagnostic}"] timeout=30s
20+
Wait Until Page Contains Element css:.cm-lsp-diagnostic[title="${diagnostic}"] timeout=35s
2121
Capture Page Screenshot 0x-${diagnostic}.png
2222
END
2323
Clean Up After Working With File Foreign Extractors.ipynb

atest/04_Interface/DiagnosticsPanel.robot

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ Diagnostics Panel Can Be Restored
3737
[Teardown] Clean Up After Working With File Panel.ipynb
3838

3939
*** Keywords ***
40-
Gently Reset Workspace
41-
Lab Command Close All Tabs
42-
4340
Open Notebook And Panel
4441
[Arguments] ${notebook}
4542
Setup Notebook Python ${notebook}

atest/05_Features/Completion.robot

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ Works With Kernel Running
1919
Completer Should Suggest TabError
2020
# this comes from LSP:
2121
Completer Should Suggest test
22-
# this comes from kernel
23-
Completer Should Suggest %%timeit
22+
# this comes from kernel; sometimes the kernel response may come a bit later
23+
Wait Until Keyword Succeeds 20x 0.5s Completer Should Suggest %%timeit
2424
Press Keys None ENTER
2525
Capture Page Screenshot 03-completion-confirmed.png
2626
${content} = Get Cell Editor Content 1
@@ -47,7 +47,7 @@ Autocompletes If Only One Option
4747
Enter Cell Editor 3 line=1
4848
Press Keys None cle
4949
Press Keys None TAB
50-
Wait Until Keyword Succeeds 20x 0.5s Cell Editor Should Equal 3 list.clear
50+
Wait Until Keyword Succeeds 40x 0.5s Cell Editor Should Equal 3 list.clear
5151
[Teardown] Clean Up After Working With File Completion.ipynb
5252

5353
User Can Select Lowercase After Starting Uppercase
@@ -56,7 +56,7 @@ User Can Select Lowercase After Starting Uppercase
5656
Trigger Completer
5757
Completer Should Suggest time
5858
Press Keys None ENTER
59-
Wait Until Keyword Succeeds 20x 0.5s Cell Editor Should Equal 4 from time import time
59+
Wait Until Keyword Succeeds 40x 0.5s Cell Editor Should Equal 4 from time import time
6060
[Teardown] Clean Up After Working With File Completion.ipynb
6161

6262
*** Keywords ***
@@ -85,4 +85,4 @@ Completer Should Not Suggest
8585

8686
Trigger Completer
8787
Press Keys None TAB
88-
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=6s
88+
Wait Until Page Contains Element ${COMPLETER_BOX} timeout=15s

atest/Keywords.robot

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Open JupyterLab
5555
${firefox} = Which firefox
5656
${geckodriver} = Which geckodriver
5757
Create WebDriver Firefox executable_path=${geckodriver} firefox_binary=${firefox} service_log_path=${OUTPUT DIR}${/}geckodriver.log
58-
Wait Until Keyword Succeeds 10x 5s Go To ${URL}lab?token=${TOKEN}
58+
Wait Until Keyword Succeeds 20x 3s Go To ${URL}lab?token=${TOKEN}
5959
Set Window Size 1024 768
6060
Wait For Splash
6161

@@ -68,7 +68,6 @@ Reset Application State
6868
Ensure All Kernels Are Shut Down
6969
Lab Command Reset Application State
7070
Wait For Splash
71-
Lab Command Close All Tabs
7271

7372
Accept Default Dialog Option
7473
[Documentation] Accept a dialog, if it exists
@@ -187,3 +186,6 @@ Close Diagnostics Panel
187186

188187
Wait For Dialog
189188
Wait Until Page Contains Element ${DIALOG WINDOW} timeout=180s
189+
190+
Gently Reset Workspace
191+
Lab Command Close All Tabs

0 commit comments

Comments
 (0)