Attempt to improve robustness and speed of CI tests

Author: krassowski

atest/01_Editor.robot

@@ -12,7 +12,7 @@ ${CM CURSORS}     css:.CodeMirror-cursors:not([style='visibility: hidden'])
 *** Test Cases ***
 Bash
     [Documentation]    TODO: figure out why the first server is extra flaky
-    Wait Until Keyword Succeeds    3x    10s    Editor Shows Features for Language    Bash    example.sh    Diagnostics=Failed to parse expression
+    Wait Until Keyword Succeeds    6x    5s    Editor Shows Features for Language    Bash    example.sh    Diagnostics=Failed to parse expression
     ...    Jump to Definition=fib
 
 CSS

atest/03_Notebook.robot

@@ -4,20 +4,20 @@ Resource          Keywords.robot
 
 *** Test Cases ***
 Python
-    [Setup]    Reset Application State
+    [Setup]    Gently Reset Workspace
     Setup Notebook    Python    Python.ipynb
     Capture Page Screenshot    01-python.png
     ${diagnostic} =    Set Variable    W291 trailing whitespace (pycodestyle)
-    Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=20s
+    Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=35s
     Capture Page Screenshot    02-python.png
     Clean Up After Working With File    Python.ipynb
 
 Foregin Extractors
-    [Setup]    Reset Application State
+    [Setup]    Gently Reset Workspace
     Setup Notebook    Python    Foreign extractors.ipynb
     @{diagnostics} =    Create List    Failed to parse expression    undefined name 'valid' (pyflakes)    Trailing whitespace is superfluous. (lintr)
     FOR    ${diagnostic}    IN    @{diagnostics}
-        Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=30s
+        Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=35s
         Capture Page Screenshot    0x-${diagnostic}.png
     END
     Clean Up After Working With File    Foreign Extractors.ipynb

atest/04_Interface/DiagnosticsPanel.robot

@@ -37,9 +37,6 @@ Diagnostics Panel Can Be Restored
     [Teardown]    Clean Up After Working With File    Panel.ipynb
 
 *** Keywords ***
-Gently Reset Workspace
-    Lab Command    Close All Tabs
-
 Open Notebook And Panel
     [Arguments]    ${notebook}
     Setup Notebook    Python    ${notebook}

atest/05_Features/Completion.robot

@@ -19,8 +19,8 @@ Works With Kernel Running
     Completer Should Suggest    TabError
     # this comes from LSP:
     Completer Should Suggest    test
-    # this comes from kernel
-    Completer Should Suggest    %%timeit
+    # this comes from kernel; sometimes the kernel response may come a bit later
+    Wait Until Keyword Succeeds    20x    0.5s    Completer Should Suggest    %%timeit
     Press Keys    None    ENTER
     Capture Page Screenshot    03-completion-confirmed.png
     ${content} =    Get Cell Editor Content    1
@@ -47,7 +47,7 @@ Autocompletes If Only One Option
     Enter Cell Editor    3    line=1
     Press Keys    None    cle
     Press Keys    None    TAB
-    Wait Until Keyword Succeeds    20x    0.5s    Cell Editor Should Equal    3    list.clear
+    Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    3    list.clear
     [Teardown]    Clean Up After Working With File    Completion.ipynb
 
 User Can Select Lowercase After Starting Uppercase
@@ -56,7 +56,7 @@ User Can Select Lowercase After Starting Uppercase
     Trigger Completer
     Completer Should Suggest  time
     Press Keys    None    ENTER
-    Wait Until Keyword Succeeds    20x    0.5s    Cell Editor Should Equal    4    from time import time
+    Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    4    from time import time
     [Teardown]    Clean Up After Working With File    Completion.ipynb
 
 *** Keywords ***
@@ -85,4 +85,4 @@ Completer Should Not Suggest
 
 Trigger Completer
     Press Keys    None    TAB
-    Wait Until Page Contains Element    ${COMPLETER_BOX}    timeout=6s
+    Wait Until Page Contains Element    ${COMPLETER_BOX}    timeout=15s

atest/Keywords.robot

@@ -55,7 +55,7 @@ Open JupyterLab
     ${firefox} =    Which    firefox
     ${geckodriver} =    Which    geckodriver
     Create WebDriver    Firefox    executable_path=${geckodriver}    firefox_binary=${firefox}    service_log_path=${OUTPUT DIR}${/}geckodriver.log
-    Wait Until Keyword Succeeds    10x    5s    Go To    ${URL}lab?token=${TOKEN}
+    Wait Until Keyword Succeeds    20x    3s    Go To    ${URL}lab?token=${TOKEN}
     Set Window Size    1024    768
     Wait For Splash
 
@@ -68,7 +68,6 @@ Reset Application State
     Ensure All Kernels Are Shut Down
     Lab Command    Reset Application State
     Wait For Splash
-    Lab Command    Close All Tabs
 
 Accept Default Dialog Option
     [Documentation]    Accept a dialog, if it exists
@@ -187,3 +186,6 @@ Close Diagnostics Panel
 
 Wait For Dialog
     Wait Until Page Contains Element    ${DIALOG WINDOW}    timeout=180s
+
+Gently Reset Workspace
+    Lab Command    Close All Tabs