Skip to content

Commit c2f6eac

Browse files
committed
Final touches in package transition
1 parent 90dd71d commit c2f6eac

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

CHANGELOG.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
- features
66

7-
- The virtual document folder can be configure with `JP_LSP_VIRTUAL_DIR` or
7+
- The virtual document folder can be configured with `JP_LSP_VIRTUAL_DIR` or
88
`LanguageServerManager.virtual_documents_dir`. Its default value is kept
99
unchanged: _contents.root_dir_ / `.virtual_documents` ([#416])
1010

@@ -19,14 +19,16 @@
1919

2020
[#403]: https://github.com/krassowski/jupyterlab-lsp/issues/403
2121

22-
### `@krassowski/jupyterlab_go_to_definition 2.0.0` (???)
22+
### `@krassowski/code-jumpers 1.0.0` (???)
2323

24-
- features
25-
26-
- breaking change: renames `uri` to `contents_path` to help avoid programmer issues
24+
- breaking change: split away from `@krassowski/go_to_definition`, rename to `@krassowski/code-jumpers` ([#423]):
25+
- remove unused code
26+
- refactor history operations to track files and always use global location data
27+
- renames `uri` to `contents_path` to help avoid programmer issues
2728
with characters requiring URI encoding ([#406])
2829

2930
[#406]: https://github.com/krassowski/jupyterlab-lsp/pull/406
31+
[#423]: https://github.com/krassowski/jupyterlab-lsp/pull/423
3032

3133
### `@krassowski/jupyterlab-lsp 2.0.8` (2020-10-25)
3234

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"private": true,
3939
"scripts": {
4040
"bootstrap": "jlpm --no-optional --prefer-offline && lerna bootstrap && jlpm lint && jlpm clean && jlpm build",
41-
"build": "jlpm build:schema && jlpm build:completion-theme && jlpm build:theme-material && jlpm build:theme-vscode && jlpm build:meta && jlpm build:ws && jlpm build:jump",
41+
"build": "jlpm build:schema && jlpm build:completion-theme && jlpm build:theme-material && jlpm build:theme-vscode && jlpm build:jump && jlpm build:meta && jlpm build:ws",
4242
"build:schema": "lerna run build:schema --stream",
4343
"build:meta": "lerna run build --stream --scope @krassowski/jupyterlab-lsp-metapackage",
4444
"build:completion-theme": "lerna run build --stream --scope @krassowski/completion-theme",

packages/metapackage/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import '@krassowski/jupyterlab_go_to_definition';
1+
import '@krassowski/code-jumpers';
22
import '@krassowski/jupyterlab-lsp';
33
import '@krassowski/completion-theme';
44
import '@krassowski/theme-material';

scripts/integrity.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@
5656
JS_LSP_NAME = "{}/jupyterlab-lsp".format(NPM_NS)
5757
JS_LSP_VERSION = PACKAGES[JS_LSP_NAME][1]["version"]
5858

59-
JS_G2D_NAME = "{}/jupyterlab_go_to_definition".format(NPM_NS)
60-
JS_G2D_VERSION = PACKAGES[JS_G2D_NAME][1]["version"]
59+
JS_CJS_NAME = "{}/code-jumpers".format(NPM_NS)
60+
JS_CJS_VERSION = PACKAGES[JS_CJS_NAME][1]["version"]
6161

6262
# py stuff
6363
PY_NAME = "jupyter-lsp"
@@ -117,7 +117,7 @@ def the_installation_notebook():
117117
[
118118
["PY_JLSP_VERSION", PY_VERSION],
119119
["JS_JLLSP_VERSION", JS_LSP_VERSION],
120-
["JS_JLG2D_VERSION", JS_G2D_VERSION],
120+
["JS_JLG2D_VERSION", JS_CJS_VERSION],
121121
],
122122
)
123123
def test_ci_variables(name, version):
@@ -179,7 +179,7 @@ def test_jlab_versions(path):
179179
[
180180
[PY_NAME, PY_VERSION],
181181
[JS_LSP_NAME, JS_LSP_VERSION],
182-
[JS_G2D_NAME, JS_G2D_VERSION],
182+
[JS_CJS_NAME, JS_CJS_VERSION],
183183
],
184184
)
185185
def test_changelog_versions(pkg, version):

0 commit comments

Comments
 (0)