Fix loose ends in completer and its tests

Author: krassowski

atest/05_Features/Completion.robot

@@ -43,9 +43,27 @@ Autocompletes If Only One Option
     Enter Cell Editor    3    line=1
     Press Keys    None    cle
     Wait Until Fully Initialized
+    # First tab brings up the completer
     Press Keys    None    TAB
+    Completer Should Suggest    clear
+    # Second tab inserts the only suggestion
+    Press Keys    None    TAB
+    # depends on Python list type having only one method with prefix "cle"
     Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    3    list.clear
 
+Does Not Autocomplete If Multiple Options
+    Enter Cell Editor    3    line=1
+    Press Keys    None    c
+    Wait Until Fully Initialized
+    # First tab brings up the completer
+    Press Keys    None    TAB
+    Completer Should Suggest    copy
+    # Second tab inserts should not insert the first of many choices.
+    Press Keys    None    TAB
+    # depends on Python list type having multiple methods with prefix "c"
+    # in this case "Completer Should Suggest" means that the completer is still shown!
+    Completer Should Suggest    copy
+
 User Can Select Lowercase After Starting Uppercase
     # `from time import Tim<tab>` → `from time import time`
     Enter Cell Editor    5    line=1
@@ -58,12 +76,16 @@ Mid Token Completions Do Not Overwrite
     # `disp<tab>data` → `display_table<cursor>data`
     Place Cursor In Cell Editor At    9    line=1    character=4
     Capture Page Screenshot    01-cursor-placed.png
-    Press Keys    None    TAB
+    Trigger Completer
+    Completer Should Suggest  display_table
+    Select Completer Suggestion    display_table
     Capture Page Screenshot    02-completed.png
     Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    9    display_tabledata
     # `disp<tab>lay` → `display_table<cursor>`
     Place Cursor In Cell Editor At    11    line=1    character=4
-    Press Keys    None    TAB
+    Trigger Completer
+    Completer Should Suggest  display_table
+    Select Completer Suggestion    display_table
     Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    11    display_table
 
 Completion Works For Tokens Separated By Space

packages/jupyterlab-lsp/src/adapters/jupyterlab/components/completion.ts

@@ -198,7 +198,7 @@ export class LSPConnector
     let connection = this._connections.get(document.id_path);
 
     console.log('[LSP][Completer] Fetching and Transforming');
-    console.log('[LSP][Completer] Token:', token);
+    console.log('[LSP][Completer] Token:', token, start, end);
 
     let lspCompletionItems = ((await connection.getCompletion(
       cursor,
@@ -278,7 +278,10 @@ export class LSPConnector
           label: item.text as string,
           insertText: item.text as string,
           type: item.type as string,
-          icon: typeof item.type === 'undefined' ? kernelIcon : undefined
+          icon:
+            typeof item.type === 'undefined' || item.type == '<unknown>'
+              ? kernelIcon
+              : undefined
         };
       });
     } else {
@@ -325,9 +328,6 @@ export class LSPConnector
       kernel.items.map(item => {
         return {
           ...item,
-          label: item.label.startsWith(prefix)
-            ? item.label.substr(prefix.length)
-            : item.label,
           insertText: item.insertText.startsWith(prefix)
             ? item.insertText.substr(prefix.length)
             : item.insertText
@@ -338,13 +338,7 @@ export class LSPConnector
     const processedItems = new Array<CompletionHandler.ICompletionItem>();
 
     aggregatedItems.forEach(item => {
-      if (
-        // For some reason the _jupyter_types_experimental list has two entries
-        // for each match, with one having a type of "<unknown>". Discard those
-        // and use undefined to indicate an unknown type.
-        insertTextSet.has(item.insertText) ||
-        (item.type && item.type === '<unknown>')
-      ) {
+      if (insertTextSet.has(item.insertText)) {
         return;
       }
       insertTextSet.add(item.insertText);