Skip to content

Commit c6fdeb0

Browse files
authored
Merge branch 'master' into add-log-window
2 parents 17a48e4 + 8f7669e commit c6fdeb0

File tree

7 files changed

+27
-29
lines changed

7 files changed

+27
-29
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- add ability to deactivate Kernel completions or LSP completion through the settings ([#586], thanks @Carreau)
88
- allow to set a priority for LSP server, allowing to choose which server to use when multiple servers are installed ([#588])
99
- add auto-detection of pyright server ([#587], thanks @yuntan)
10+
- update from JupyterLab Classic to RetroLab ([#603])
1011
- log server messages in user-accessible console ([#606])
1112
- old emit-based API of lsp-ws-connection is new deprecated and will be removed in the next major version; please use `serverNotifications`, `clientNotifications`, `clientRequests` and `serverRequests` instead ([#606])
1213

@@ -22,6 +23,7 @@
2223
[#587]: https://github.com/krassowski/jupyterlab-lsp/pull/587
2324
[#588]: https://github.com/krassowski/jupyterlab-lsp/pull/588
2425
[#599]: https://github.com/krassowski/jupyterlab-lsp/pull/599
26+
[#602]: https://github.com/krassowski/jupyterlab-lsp/pull/602
2527
[#606]: https://github.com/krassowski/jupyterlab-lsp/pull/606
2628

2729
### `jupyter-lsp 1.2.0` (2021-04-26)

binder/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ dependencies:
88
# runtime dependencies
99
- python >=3.6,<3.9.0a0
1010
- jupyterlab >=3.0.0,<4.0.0a0
11-
- jupyterlab-classic >=0.1.3,<0.2
1211
- jupyter_server >=1.1.2
12+
- retrolab >=0.2.0,<0.3
1313
# build dependencies
1414
- nodejs >=12,<15
1515
# for python language server (and development)

packages/_example-extractor/jest.config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ let local = {
1717
'\\.(js|jsx)?$': './transform.js',
1818
'\\.svg$': 'jest-raw-loader'
1919
},
20-
transformIgnorePatterns: [
21-
'/node_modules/(?!(@jupyterlab/.*|@jupyterlab-classic/.*)/)'
22-
],
20+
transformIgnorePatterns: ['/node_modules/(?!(@jupyterlab/.*|@retrolab/.*)/)'],
2321
testLocationInResults: true,
2422
reporters: [...upstream['reporters'], 'jest-github-actions-reporter']
2523
};

packages/jupyterlab-lsp/jest.config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ let local = {
1717
'\\.(js|jsx)?$': './transform.js',
1818
'\\.svg$': 'jest-raw-loader'
1919
},
20-
transformIgnorePatterns: [
21-
'/node_modules/(?!(@jupyterlab/.*|@jupyterlab-classic/.*)/)'
22-
],
20+
transformIgnorePatterns: ['/node_modules/(?!(@jupyterlab/.*|@retrolab/.*)/)'],
2321
testLocationInResults: true,
2422
reporters: [...upstream['reporters'], 'jest-github-actions-reporter']
2523
};

packages/jupyterlab-lsp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
},
6767
"devDependencies": {
6868
"@babel/preset-env": "^7.4.3",
69-
"@jupyterlab-classic/application": "^0.1.2",
7069
"@jupyterlab/application": "^3.0.0",
7170
"@jupyterlab/apputils": "^3.0.0",
7271
"@jupyterlab/builder": "^3.0.0",
@@ -87,6 +86,7 @@
8786
"@jupyterlab/tooltip": "^3.0.0",
8887
"@lumino/algorithm": "*",
8988
"@lumino/widgets": "^1.16.1",
89+
"@retrolab/application": "^0.2.0",
9090
"@types/chai": "^4.1.7",
9191
"@types/codemirror": "^0.0.74",
9292
"@types/events": "^3.0.0",

packages/jupyterlab-lsp/src/adapter_manager.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import type { IClassicShell } from '@jupyterlab-classic/application';
21
import { ILabShell, JupyterFrontEndPlugin } from '@jupyterlab/application';
32
import { IDocumentWidget } from '@jupyterlab/docregistry';
43
import { Signal } from '@lumino/signaling';
4+
import type { IRetroShell } from '@retrolab/application';
55

66
import { WidgetAdapter } from './adapters/adapter';
77
import {
@@ -29,7 +29,7 @@ export class WidgetAdapterManager implements ILSPAdapterManager {
2929
return this.adapterTypes;
3030
}
3131

32-
constructor(protected shell: ILabShell | IClassicShell) {
32+
constructor(protected shell: ILabShell | IRetroShell) {
3333
this.adapterChanged = new Signal(this);
3434
this.adapterDisposed = new Signal(this);
3535
this.adapterTypeAdded = new Signal(this);
@@ -146,7 +146,7 @@ export class WidgetAdapterManager implements ILSPAdapterManager {
146146
export const WIDGET_ADAPTER_MANAGER: JupyterFrontEndPlugin<ILSPAdapterManager> = {
147147
id: PLUGIN_ID + ':ILSPAdapterManager',
148148
activate: app => {
149-
let shell = app.shell as ILabShell | IClassicShell;
149+
let shell = app.shell as ILabShell | IRetroShell;
150150
return new WidgetAdapterManager(shell);
151151
},
152152
provides: ILSPAdapterManager,

yarn.lock

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,23 +1193,6 @@
11931193
resolved "https://registry.yarnpkg.com/@joe-re/sql-parser/-/sql-parser-0.11.5.tgz#8382dac1aaec3ebd1acd245bbbab1825e96e0648"
11941194
integrity sha512-0WL/ibfrcY00MoDS/zffNTQqnvxpeWVwslODCLgMr96A6bC8huEzQh3byk1gEkSIjClCb1TLOjwr37mSbei6Fw==
11951195

1196-
"@jupyterlab-classic/application@^0.1.2":
1197-
version "0.1.2"
1198-
resolved "https://registry.yarnpkg.com/@jupyterlab-classic/application/-/application-0.1.2.tgz#6b5946e13c705a1142ae9bb06e16b00658c237be"
1199-
integrity sha512-9XP3G35QI5hKpG09+51Kl5jDIXbbPkaVQwZiILYbao198LLlSzW6aYHJFjl9JNr2zEXOn4KmLA995BDraSNnIw==
1200-
dependencies:
1201-
"@jupyterlab/application" "^3.0.0"
1202-
"@jupyterlab/coreutils" "^5.0.0"
1203-
"@jupyterlab/docregistry" "^3.0.0"
1204-
"@jupyterlab/ui-components" "^3.0.0"
1205-
"@lumino/algorithm" "^1.3.3"
1206-
"@lumino/coreutils" "^1.5.3"
1207-
"@lumino/messaging" "^1.4.3"
1208-
"@lumino/polling" "^1.3.3"
1209-
"@lumino/signaling" "^1.4.3"
1210-
"@lumino/widgets" "^1.14.0"
1211-
es6-promise "~4.2.8"
1212-
12131196
"@jupyterlab/application@^3.0.0":
12141197
version "3.0.0"
12151198
resolved "https://registry.yarnpkg.com/@jupyterlab/application/-/application-3.0.0.tgz#791dacd18c6353333a675d9f6ca457c7da3216b6"
@@ -2984,6 +2967,23 @@
29842967
dependencies:
29852968
"@types/node" ">= 8"
29862969

2970+
"@retrolab/application@^0.2.0":
2971+
version "0.2.1"
2972+
resolved "https://registry.yarnpkg.com/@retrolab/application/-/application-0.2.1.tgz#8194a4e0b5ab284e327014a2d3c1c5a1daa4732f"
2973+
integrity sha512-5mi1rvPvwUFhbZH5ESdSxW7mL//pbFqHGBysvLa7S5muWllRe4KsVm0EgZSU8XOlEwGuDtnyGguBjc5P8CFfIg==
2974+
dependencies:
2975+
"@jupyterlab/application" "^3.0.0"
2976+
"@jupyterlab/coreutils" "^5.0.0"
2977+
"@jupyterlab/docregistry" "^3.0.0"
2978+
"@jupyterlab/rendermime-interfaces" "^3.0.0"
2979+
"@jupyterlab/ui-components" "^3.0.0"
2980+
"@lumino/algorithm" "^1.3.3"
2981+
"@lumino/coreutils" "^1.5.3"
2982+
"@lumino/messaging" "^1.4.3"
2983+
"@lumino/polling" "^1.3.3"
2984+
"@lumino/signaling" "^1.4.3"
2985+
"@lumino/widgets" "^1.14.0"
2986+
29872987
"@sindresorhus/is@^0.14.0":
29882988
version "0.14.0"
29892989
resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.14.0.tgz#9fb3a3cf3132328151f353de4632e01e52102bea"
@@ -6252,7 +6252,7 @@ es6-iterator@^2.0.3, es6-iterator@~2.0.3:
62526252
es5-ext "^0.10.35"
62536253
es6-symbol "^3.1.1"
62546254

6255-
es6-promise@^4.0.3, es6-promise@~4.2.8:
6255+
es6-promise@^4.0.3:
62566256
version "4.2.8"
62576257
resolved "https://registry.yarnpkg.com/es6-promise/-/es6-promise-4.2.8.tgz#4eb21594c972bc40553d276e510539143db53e0a"
62586258
integrity sha512-HJDGx5daxeIvxdBxvG2cb9g4tEvwIk3i8+nhX0yGrYmZUzbkdg8QbDevheDB8gd0//uPj4c1EQua8Q+MViT0/w==

0 commit comments

Comments
 (0)