use ICodeMirror, more type imports, order plugin for fixer

Author: bollwyvl

package.json

@@ -25,8 +25,8 @@
     "vscode-css-languageserver-bin": "^1.4.0",
     "vscode-html-languageserver-bin": "^1.4.0",
     "vscode-json-languageserver-bin": "^1.0.1",
-    "yaml-language-server": "^0.12.0",
-    "vscode-json-languageservice": "^3.9.1 <3.10.0"
+    "vscode-json-languageservice": "^3.9.1 <3.10.0",
+    "yaml-language-server": "^0.12.0"
   },
   "husky": {
     "hooks": {}

packages/.eslintrc.js

@@ -10,6 +10,9 @@ module.exports = {
   root: true,
   extends: [
     'eslint:recommended',
+    'plugin:import/errors',
+    'plugin:import/warnings',
+    'plugin:import/typescript',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'prettier/@typescript-eslint',
@@ -55,12 +58,32 @@ module.exports = {
     'no-undef': 'warn',
     'no-useless-escape': 'off',
     'prefer-const': 'off',
-    // deviations from jupyterlab, should not be changed
-    // a pitfall of enums is that they do not work correctly
-    // when circular dependencies are present
-    // (see https://stackoverflow.com/a/59665223/)
-    'import/no-cycle': 'error',
+    // the default, but for reference...
+    'import/order': [
+      'warn',
+      {
+        groups: [
+          'builtin',
+          'external',
+          'parent',
+          'sibling',
+          'index',
+          'object',
+          'unknown'
+        ],
+        pathGroups: [
+          { pattern: 'react/**', group: 'builtin', order: 'after' },
+          { pattern: 'codemirror/**', group: 'external', order: 'before' },
+          { pattern: '@lumino/**', group: 'external', order: 'before' },
+          { pattern: '@jupyterlab/**', group: 'external', order: 'after' }
+        ],
+        'newlines-between': 'always',
+        alphabetize: { order: 'asc' }
+      }
+    ],
     // deviations from jupyterlab, should probably be fixed
+    'import/no-cycle': 'off', // somehow we lapsed here... ~200 cycles now
+    'import/export': 'off', // we do class/interface + NS pun exports _all over_
     '@typescript-eslint/triple-slash-reference': 'off',
     'jest/no-test-callback': 'off',
     'jest/valid-expect': 'off',

packages/_example-extractor/src/api.spec.ts

@@ -1,9 +1,8 @@
+import { IExtractedCode } from '@krassowski/jupyterlab-lsp';
 import { expect } from 'chai';
 
 import { extractor } from '.';
 
-import { IExtractedCode } from '@krassowski/jupyterlab-lsp';
-
 const EXAMPLE = `%%foo
 bar
 `;

packages/_example-extractor/src/index.ts

@@ -2,7 +2,6 @@ import {
   JupyterFrontEnd,
   JupyterFrontEndPlugin
 } from '@jupyterlab/application';
-
 import {
   ILSPCodeExtractorsManager,
   RegExpForeignCodeExtractor

packages/code-jumpers/src/history.ts

@@ -1,7 +1,8 @@
-import { IGlobalPosition } from './positions';
 import { IModelDB, IObservableUndoableList } from '@jupyterlab/observables';
 import { JSONValue } from '@lumino/coreutils';
 
+import { IGlobalPosition } from './positions';
+
 const DB_ENTRY = 'jumpy_history';
 
 export class JumpHistory {

packages/code-jumpers/src/index.ts

@@ -1,5 +1,5 @@
+import { FileEditorJumper } from './jumpers/fileeditor';
 import { CodeJumper } from './jumpers/jumper';
 import { NotebookJumper } from './jumpers/notebook';
-import { FileEditorJumper } from './jumpers/fileeditor';
 
 export { CodeJumper, NotebookJumper, FileEditorJumper };

packages/code-jumpers/src/jumpers/fileeditor.ts

@@ -1,10 +1,12 @@
+import { CodeEditor } from '@jupyterlab/codeeditor';
+import { IDocumentManager } from '@jupyterlab/docmanager';
+import { IDocumentWidget } from '@jupyterlab/docregistry';
 import { FileEditor } from '@jupyterlab/fileeditor';
+
+import { JumpHistory } from '../history';
 import { IGlobalPosition, ILocalPosition } from '../positions';
+
 import { CodeJumper, jumpers } from './jumper';
-import { JumpHistory } from '../history';
-import { IDocumentManager } from '@jupyterlab/docmanager';
-import { IDocumentWidget } from '@jupyterlab/docregistry';
-import { CodeEditor } from '@jupyterlab/codeeditor';
 
 export class FileEditorJumper extends CodeJumper {
   editor: FileEditor;

packages/code-jumpers/src/jumpers/jumper.ts

@@ -1,12 +1,13 @@
+import { Dialog, showDialog } from '@jupyterlab/apputils';
 import { CodeEditor } from '@jupyterlab/codeeditor';
-
-import { IGlobalPosition, ILocalPosition } from '../positions';
 import { IDocumentManager } from '@jupyterlab/docmanager';
 import { IDocumentWidget } from '@jupyterlab/docregistry';
-import { JumpHistory } from '../history';
 import { FileEditor } from '@jupyterlab/fileeditor';
+
+import { JumpHistory } from '../history';
+import { IGlobalPosition, ILocalPosition } from '../positions';
+
 import IEditor = CodeEditor.IEditor;
-import { Dialog, showDialog } from '@jupyterlab/apputils';
 
 const movement_keys = [
   'ArrowRight',

packages/code-jumpers/src/jumpers/notebook.ts

@@ -1,11 +1,12 @@
-import { Notebook, NotebookPanel } from '@jupyterlab/notebook';
+import { CodeEditor } from '@jupyterlab/codeeditor';
 import { IDocumentManager } from '@jupyterlab/docmanager';
+import { Notebook, NotebookPanel } from '@jupyterlab/notebook';
 
-import { CodeJumper, jumpers } from './jumper';
-import { IGlobalPosition, ILocalPosition } from '../positions';
-import { _ensureFocus } from '../notebook_private';
 import { JumpHistory } from '../history';
-import { CodeEditor } from '@jupyterlab/codeeditor';
+import { _ensureFocus } from '../notebook_private';
+import { IGlobalPosition, ILocalPosition } from '../positions';
+
+import { CodeJumper, jumpers } from './jumper';
 
 export class NotebookJumper extends CodeJumper {
   notebook: Notebook;

packages/completion-theme/src/about.tsx

@@ -1,10 +1,11 @@
+import { LabIcon } from '@jupyterlab/ui-components';
 import React, { ReactElement } from 'react';
+
 import {
+  COMPLETER_THEME_PREFIX,
   ICompletionTheme,
-  ILicenseInfo,
-  COMPLETER_THEME_PREFIX
+  ILicenseInfo
 } from './types';
-import { LabIcon } from '@jupyterlab/ui-components';
 
 function render_licence(licence: ILicenseInfo): ReactElement {
   return (