Merge pull request #580 from stonebig/patch-1

patch jupyter_lsp-1.1.4 for 'native' Windows users

Author: krassowski

CHANGELOG.md

@@ -10,10 +10,12 @@
 
   - fixed name of jupyterlab-lsp package displayed in JupyterLab UI ([#570], thanks @marimeireles)
   - removed vendored CodeMirror from distribution ([#576])
+  - fix encoding on Windows for non-conda installs ([#580], thanks @stonebig)
 
 [#557]: https://github.com/krassowski/jupyterlab-lsp/pull/557
 [#570]: https://github.com/krassowski/jupyterlab-lsp/pull/570
 [#576]: https://github.com/krassowski/jupyterlab-lsp/pull/576
+[#580]: https://github.com/krassowski/jupyterlab-lsp/pull/580
 
 ### `@krassowski/jupyterlab-lsp 3.5.0` (2020-03-22)
 

python_packages/jupyter_lsp/jupyter_lsp/virtual_documents_shadow.py

@@ -41,15 +41,15 @@ def read_lines(self):
         lines = [""]
         try:
             # TODO: what to do about bad encoding reads?
-            lines = self.path.read_text().splitlines()
+            lines = self.path.read_text(encoding='utf-8').splitlines()
         except FileNotFoundError:
             pass
         return lines
 
     @run_on_executor
     def write_lines(self):
         self.path.parent.mkdir(parents=True, exist_ok=True)
-        self.path.write_text("\n".join(self.lines))
+        self.path.write_text("\n".join(self.lines), encoding='utf-8')
 
     @staticmethod
     def trim(lines: list, character: int, side: int):