Merge pull request #584 from krassowski/switch-to-pyls-fork

Switch to python-lsp-server for testing

Author: krassowski

README.md

@@ -119,19 +119,19 @@ Use of a python `virtualenv` or a conda env is also recommended.
    > or `jupyter-lsp-r` to install both the server extension and the language server.
 
 1. install LSP servers for languages of your choice; for example, for Python
-   ([pyls](https://github.com/palantir/python-language-server)) and
+   ([pylsp](https://github.com/python-lsp/python-lsp-server)) and
    R ([languageserver](https://github.com/REditorSupport/languageserver)) servers:
 
    ```bash
    # note: you may want to use our fork of python-language-server instead (see below)
-   pip install 'python-language-server[all]'
+   pip install 'python-lsp-server[all]'
    R -e 'install.packages("languageserver")'
    ```
 
    or from `conda-forge`
 
    ```bash
-   conda install -c conda-forge python-language-server r-languageserver
+   conda install -c conda-forge python-lsp-server r-languageserver
    ```
 
    Please see our full list of
@@ -188,6 +188,8 @@ Use of a python `virtualenv` or a conda env is also recommended.
 
 Server configurations can be edited using the Advanced Settings editor in JupyterLab (_Settings > Advanced Settings Editor_). For settings specific to each server, please see the [table of language servers][language-servers]. Example settings might include:
 
+> Note: for the new (currently recommended) python-lsp-server replace `pyls` occurrences with `pyslp`
+
 ```json
 {
   "language_servers": {

atest/05_Features/Completion.robot

@@ -187,7 +187,7 @@ Completion Works For Tokens Separated By Space
     Wait Until Keyword Succeeds    40x    0.5s    Cell Editor Should Equal    13    from statistics import
 
 Kernel And LSP Completions Merge Prefix Conflicts Are Resolved
-    [Documentation]    Reconciliate Python kernel returning prefixed completions and LSP (pyls) not-prefixed ones
+    [Documentation]    Reconciliate Python kernel returning prefixed completions and LSP (pylsp) not-prefixed ones
     Configure JupyterLab Plugin    {"kernelResponseTimeout": -1, "waitForBusyKernel": false}    plugin id=${COMPLETION PLUGIN ID}
     # For more details see: https://github.com/krassowski/jupyterlab-lsp/issues/30#issuecomment-576003987
     # `import os.pat<tab>` → `import os.pathsep`

atest/07_Configuration.robot

@@ -7,8 +7,8 @@ Resource          ./Keywords.robot
 *** Test Cases ***
 Python
     [Documentation]    pyflakes is enabled by default, but flake8 is not
-    Settings Should Change Editor Diagnostics    Python    style.py    pyls
-    ...    {"pyls": {"plugins": {"flake8": {"enabled": true},"pyflakes": {"enabled": false}}}}
+    Settings Should Change Editor Diagnostics    Python    style.py    pylsp
+    ...    {"pylsp": {"plugins": {"flake8": {"enabled": true},"pyflakes": {"enabled": false}}}}
     ...    undefined name 'foo' (pyflakes)
     ...    undefined name 'foo' (flake8)
 

atest/Variables.robot

@@ -54,5 +54,5 @@ ${JLAB XP CLOSE SETTINGS}    ${JLAB XP DOCK TAB}\[contains(., 'Settings')]/*[con
 ${CSS DIAGNOSTIC}    css:.cm-lsp-diagnostic
 # log messages
 @{KNOWN BAD ERRORS}
-...               pyls_jsonrpc.endpoint - Failed to handle notification
-...               pyls_jsonrpc.endpoint - Failed to handle request
+...               pylsp_jsonrpc.endpoint - Failed to handle notification
+...               pylsp_jsonrpc.endpoint - Failed to handle request

binder/environment.yml

@@ -19,7 +19,7 @@ dependencies:
   - pyls-black
   - pyls-isort
   - pyls-mypy
-  - python-language-server
+  - python-lsp-server
   - ruamel_yaml
   # for R language server and kernel
   - r

docs/rtd.yml

@@ -17,7 +17,7 @@ dependencies:
       - pandas
       - pytest-check-links
       - myst-nb
-      - python-language-server
+      - python-lsp-server
       - sphinx
       - sphinx-autodoc-typehints
       - sphinx-copybutton

python_packages/jupyter_lsp/jupyter_lsp/specs/config/python-lsp-server.schema.json renamed to python_packages/jupyter_lsp/jupyter_lsp/specs/config/pylsp.schema.json

@@ -3,10 +3,10 @@
 
 
 class PythonLSPServer(PythonModuleSpec):
-    python_module = key = "python-lsp-server"
+    python_module = key = "pylsp"
     languages = ["python"]
     spec = dict(
-        display_name="python-lsp-server",
+        display_name="python-lsp-server (pylsp)",
         mime_types=["text/python", "text/x-ipython"],
         urls=dict(
             home="https://github.com/python-lsp/python-lsp-server",

python_packages/jupyter_lsp/jupyter_lsp/specs/python_lsp_server.py

@@ -19,7 +19,7 @@
     "bash-language-server",
     "dockerfile-language-server-nodejs",
     "javascript-typescript-langserver",
-    "pyls",
+    "pylsp",
     "unified-language-server",
     "sql-language-server",
     "vscode-css-languageserver-bin",

python_packages/jupyter_lsp/jupyter_lsp/tests/conftest.py

@@ -78,7 +78,7 @@ async def test_start_unknown(known_unknown_server, handlers, jsonrpc_init_msg):
 @pytest.mark.asyncio
 async def test_ping(handlers):
     """see https://github.com/krassowski/jupyterlab-lsp/issues/458"""
-    a_server = "pyls"
+    a_server = "pylsp"
 
     handler, ws_handler = handlers
     manager = handler.manager