add some docs, remove some logging use of decodeURI

bollwyvl · bollwyvl · commit d43b547f559a · 2020-11-18T20:23:14.000-05:00
diff --git a/packages/jupyterlab-go-to-definition/src/jump.ts b/packages/jupyterlab-go-to-definition/src/jump.ts
@@ -37,5 +37,8 @@ export interface IGlobalJump {
   line: number;
   column: number;
 
+  /**
+   * The Jupyter ContentsManager path, _not_ passed through encode URI.
+   */
   contents_path: string;
 }
diff --git a/packages/jupyterlab-lsp/src/editor_integration/codemirror.ts b/packages/jupyterlab-lsp/src/editor_integration/codemirror.ts
@@ -281,11 +281,7 @@ export abstract class CodeMirrorIntegration
 
       if (!uris_equal(uri, current_uri)) {
         errors.push(
-          'Workspace-wide edits not implemented (' +
-            decodeURI(uri) +
-            ' != ' +
-            decodeURI(current_uri) +
-            ')'
+          `Workspace-wide edits not implemented: ${uri} != ${current_uri}`
         );
       } else {
         is_whole_document_edit =

Original file line number	Diff line number	Diff line change
`@@ -37,5 +37,8 @@ export interface IGlobalJump {`
`37`	`37`	`line: number;`
`38`	`38`	`column: number;`
`39`	`39`
	`40`	`+ /**`
	`41`	`+ * The Jupyter ContentsManager path, _not_ passed through encode URI.`
	`42`	`+ */`
`40`	`43`	`contents_path: string;`
`41`	`44`	`}`